Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: set UseTransactionalDescIDGenerator testing knob in SQLTranslator tests #110829

Merged
merged 2 commits into from
Sep 18, 2023
Merged

testing: set UseTransactionalDescIDGenerator testing knob in SQLTranslator tests #110829

merged 2 commits into from
Sep 18, 2023

Conversation

ecwall
Copy link
Contributor

@ecwall ecwall commented Sep 18, 2023 •
edited by rafiss
Loading

Fixes #110242
Fixes #110240

Set UseTransactionalDescIDGenerator to true to prevent transaction retries from
resulting in different descriptor IDs. Descriptor IDs appear directly in the test
output and must remain stable.

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ecwall ecwall changed the title Txn desc testing: set UseTransactionalDescIDGenerator testing knob in SQLTranslator tests Sep 18, 2023
@ecwall
Revert "testing: add table id placeholder in multi-node SQLTranslator…
60d895f 
… tests"

This reverts commit 9bfb5da.

Release note: None
@ecwall
testing: set UseTransactionalDescIDGenerator testing knob in SQLTrans…
b232ffe 
…lator tests

Fixes #110242

Set UseTransactionalDescIDGenerator to true to prevent transaction retries from
resulting in different descriptor IDs. Descriptor IDs appear directly in the test
output and must remain stable.

Release note: None
@ecwall ecwall added the backport-23.1.x Flags PRs that need to be backported to 23.1 label Sep 18, 2023
@ecwall ecwall marked this pull request as ready for review September 18, 2023 17:00
@ecwall ecwall requested a review from a team as a code owner September 18, 2023 17:00
@ecwall ecwall requested review from knz and rafiss September 18, 2023 18:10
rafiss
rafiss approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 26 of 26 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @knz)

@rafiss rafiss mentioned this pull request Sep 18, 2023
Closed
@ecwall
Copy link
Contributor Author

ecwall commented Sep 18, 2023

bors r=rafiss

@craig
Copy link
Contributor

craig bot commented Sep 18, 2023

Build succeeded:

@craig craig bot merged commit 0b2ced7 into cockroachdb:master Sep 18, 2023
@blathers-crl blathers-crl bot mentioned this pull request Sep 18, 2023
Merged
This was referenced Sep 18, 2023
Closed
Closed
Closed
Closed
@rafiss
Copy link
Collaborator

rafiss commented Sep 22, 2023

blathers backport 23.1.11-rc

@blathers-crl blathers-crl bot mentioned this pull request Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiss rafiss rafiss approved these changes

@knz knz Awaiting requested review from knz

Assignees
No one assigned
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Milestone
No milestone
3 participants
@ecwall @cockroach-teamcity @rafiss