spanconfigccl: stablize the test expectations in TestDataDriven #110492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rafiss
added
backport-23.1.x
knz
force-pushed
the
20230912-sc-ids
branch
from
a13a267 to
31d3ea9
Compare
See explanation in cockroachdb#110487: table ID 109 and others result in weird output test expectations. Also, a multi-node cluster doens't allocate the same number of objects (or doesn't use the desc ID sequence in the same way) resulting in non-stable table IDs. Release note: None Co-authored-by: Evan Wall <[email protected]>
knz
force-pushed
the
20230912-sc-ids
branch
from
31d3ea9 to
7c7c99b
Compare
ecwall
reviewed
Sep 12, 2023
| /Tenant/10/Table/11{0-1} range default | ||
| /Tenant/10/Table/11{1-2} range default | ||
| /Tenant/10/Table/11{2-3} range default | ||
| [/Tenant/10, /Tenant/10/Table/4) database system (tenant) |
There was a problem hiding this comment.
It looks like the output is incorrect for this since there are multiple tables being checked.
|
closing in favor of #110829 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110242
Epic: CRDB-28893
See explanation in #110487: table ID 109 and others result in weird output test expectations. Also, a multi-node cluster doens't allocate the same number of objects (or doesn't use the desc ID sequence in the same way) resulting in non-stable table IDs.
Release note: None