Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: changefeedccl: Fix potential shutdown NPE #110824

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 18, 2023

Backport 1/1 commits from #110773 on behalf of @miretskiy.

/cc @cockroachdb/release


A flow may be cancelled immediately after it's created, before it has Started. If this happens, change aggregator may panic because certain state may not be initialized.

Fixes #110772

Release note: None


Release justification: bug fix

A flow may be cancelled immediately after it's created,
before it has `Start`ed.  If this happens, change aggregator
may panic because certain state may not be initialized.

Fixes #110772

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner September 18, 2023 15:57
@blathers-crl blathers-crl bot removed the request for review from a team September 18, 2023 15:57
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-110773 branch from c30cb16 to e0c8bf5 Compare September 18, 2023 15:57
@blathers-crl blathers-crl bot requested a review from miretskiy September 18, 2023 15:57
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 18, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-110773 branch from e45a043 to 004cb4d Compare September 18, 2023 15:57
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Sep 18, 2023
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Sep 18, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 18, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@miretskiy miretskiy merged commit ea44a50 into release-22.2 Sep 18, 2023
@miretskiy miretskiy deleted the blathers/backport-release-22.2-110773 branch September 18, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants