changefeedccl: Fix potential shutdown NPE #110773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A flow may be cancelled immediately after it's created, before it has `Start`ed. If this happens, change aggregator may panic because certain state may not be initialized. Fixes cockroachdb#110772 Release note: None
miretskiy
added
backport-22.2.x
backport-23.1.x
miretskiy
requested review from
jayshrivastava
and removed request for
a team
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
jayshrivastava
approved these changes
Sep 18, 2023
|
bors r+ |
|
Build succeeded: |
This was referenced Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A flow may be cancelled immediately after it's created, before it has
Started. If this happens, change aggregator may panic because certain state may not be initialized.Fixes #110772
Release note: None