Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: roachtest: remove old executables before installing ruby #110716

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

smg260
Copy link
Contributor

@smg260 smg260 commented Sep 15, 2023

Backport 1/1 commits from #100764.

/cc @cockroachdb/release


This backport was already applied to 23.x where it fixed a specific ruby installation flake, which has continued occurring on 22.2

Release note: None
Release justification: test-only change

Fixes: #108661
Fixes: #109145

This should prevent errors during installation.

Release note: None
@blathers-crl
Copy link

blathers-crl bot commented Sep 15, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Sep 15, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@smg260 smg260 requested a review from rafiss September 15, 2023 13:47
@smg260 smg260 marked this pull request as ready for review September 15, 2023 13:47
@smg260 smg260 requested review from a team, rachitgsrivastava, DarrylWong and srosenberg and removed request for a team, rachitgsrivastava and DarrylWong September 15, 2023 13:47
@smg260 smg260 merged commit 2a0b4bb into cockroachdb:release-22.2 Sep 15, 2023
@smg260 smg260 deleted the backport22.2-100764 branch September 27, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants