Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: remove old executables before installing ruby #100764

Merged
merged 1 commit into from
Apr 6, 2023
Merged

roachtest: remove old executables before installing ruby #100764

merged 1 commit into from
Apr 6, 2023

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Apr 5, 2023

This should prevent errors during installation.

fixes #95004
fixes #100428
backport fixes #100586

Release note: None

@rafiss
roachtest: remove old executables before installing ruby
7670dc6 
This should prevent errors during installation.

Release note: None
@rafiss rafiss added the backport-23.1.x Flags PRs that need to be backported to 23.1 label Apr 5, 2023
@rafiss rafiss requested review from smg260 and andyyang890 April 5, 2023 22:03
@rafiss rafiss requested a review from a team as a code owner April 5, 2023 22:03
@rafiss rafiss requested review from renatolabs and removed request for a team April 5, 2023 22:03
@cockroach-teamcity
Copy link
Member

This change is Reviewable

andyyang890
andyyang890 approved these changes Apr 6, 2023
View reviewed changes
Copy link
Collaborator

@andyyang890 andyyang890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rafiss
Copy link
Collaborator Author

rafiss commented Apr 6, 2023

tftr

bors r+

@rafiss
Copy link
Collaborator Author

rafiss commented Apr 6, 2023

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 6, 2023

Build succeeded:

@craig craig bot merged commit 15182c7 into cockroachdb:master Apr 6, 2023
@blathers-crl blathers-crl bot mentioned this pull request Apr 6, 2023
Merged
@rafiss rafiss deleted the fix-ruby-test branch April 6, 2023 17:33
This was referenced Sep 14, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyyang890 andyyang890 andyyang890 approved these changes

@smg260 smg260 Awaiting requested review from smg260

@renatolabs renatolabs Awaiting requested review from renatolabs renatolabs was automatically assigned from cockroachdb/test-eng

Assignees
No one assigned
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Milestone
No milestone
3 participants
@rafiss @cockroach-teamcity @andyyang890