Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: sql: implement oidvectortypes builtin #109711

Merged
merged 1 commit into from
Aug 30, 2023
Merged

release-23.1: sql: implement oidvectortypes builtin #109711

merged 1 commit into from
Aug 30, 2023

Conversation

fqazi
Copy link
Collaborator

@fqazi fqazi commented Aug 30, 2023 •
edited
Loading

Backport 1/1 commits from #108467.

/cc @cockroachdb/release

Previously, the oidvectortypes builtin in wasn't implemented, causing a compatibility gap for tools
that need to format oidvectors. To address this, this patch adds the oidvectortypes built in.

Fixes: #107942

Release note (sql change): The oidvectortypes built-in has been implemented, which can format oidvector.

Release justification: low risk and backports a simple builtin for ORMs

@fqazi
sql: implement oidvectortypes builtin
e058c0d 
Previously, the oidvectortypes builtin in wasn't implemented, causing
a compatibility gap for tools that need to format oidvectors. To
address this, this patch adds the oidvectortypes built in.

Fixes: cockroachdb#107942

Release note (sql change): The oidvectortypes built-in has been implemented,
which can format oidvector.
@fqazi fqazi requested a review from a team as a code owner August 30, 2023 02:25
@blathers-crl
Copy link

blathers-crl bot commented Aug 30, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Aug 30, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss merged commit a104323 into cockroachdb:release-23.1 Aug 30, 2023
@cockroach-teamcity cockroach-teamcity mentioned this pull request Aug 31, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiss rafiss rafiss approved these changes

Assignees
No one assigned
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fqazi @cockroach-teamcity @rafiss