sql: implement oidvectortypes builtin

[fqazi]

Previously, the oidvectortypes builtin in wasn't implemented, causing a compatibility gap for tools
that need to format oidvectors. To address this, this patch adds the oidvectortypes built in.

Fixes: #107942

Release note (sql change): The oidvectortypes built-in has been implemented, which can format oidvector.

[cockroach-teamcity]

This change is 

[rafiss]

nice! just have small comments

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @fqazi)

---

pkg/sql/sem/builtins/builtins.go line 4012 at r1 (raw file):

					oidDatum := datum.(*tree.DOid)
					var typ *types.T
					if resolvedTyp, ok := types.OidToType[oidDatum.Oid]; ok {

does ResolveTypeByOID not already have this logic? not a huge deal, but just curious

---

pkg/sql/sem/builtins/builtins.go line 4020 at r1 (raw file):

						}
					}
					result.WriteString(typ.SQLString())

i believe we want typ.Name(). compare with postgres to see which format it uses.

---

pkg/sql/sem/builtins/builtins.go line 4027 at r1 (raw file):

				return tree.NewDString(result.String()), nil
			},
			Info:       "Generates a comma seperated string of type names from an oidvector",

nit: period at the end

---

pkg/sql/logictest/testdata/logic_test/builtin_function line 4042 at r1 (raw file):

query T rowsort
SELECT oidvectortypes(proargtypes) FROM pg_proc WHERE oid=263

could you add a test for a UDF that has user-defined types as arg types?

[fqazi]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @rafiss)

---

pkg/sql/sem/builtins/builtins.go line 4012 at r1 (raw file):

Previously, rafiss (Rafi Shamim) wrote…

does ResolveTypeByOID not already have this logic? not a huge deal, but just curious

Sadly, it doesn't. I started off just calling that, but then builtin types didn't work :/

---

pkg/sql/sem/builtins/builtins.go line 4020 at r1 (raw file):

Previously, rafiss (Rafi Shamim) wrote…

i believe we want typ.Name(). compare with postgres to see which format it uses.

Done.

---

pkg/sql/logictest/testdata/logic_test/builtin_function line 4042 at r1 (raw file):

Previously, rafiss (Rafi Shamim) wrote…

could you add a test for a UDF that has user-defined types as arg types?

Done.

[rafiss]

lgtm!

Reviewable status: complete! 0 of 0 LGTMs obtained

[fqazi]

@rafiss TFTR!

bors r+

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error creating merge commit from a24025d to blathers/backport-release-23.1-108467: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)