Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgwire: avoid mentioning "tenants" in pre-serve metric descriptions #109076

Merged
merged 1 commit into from
Aug 21, 2023
Merged

pgwire: avoid mentioning "tenants" in pre-serve metric descriptions #109076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions pkg/sql/pgwire/pre_serve.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,37 +39,37 @@ import (
var (
MetaPreServeNewConns = metric.Metadata{
Name: "sql.pre_serve.new_conns",
Help: "Counter of the number of SQL connections created prior to routine the connection a specific tenant",
Help: "Number of SQL connections created prior to routing the connection to the target SQL server",
Measurement: "Connections",
Unit: metric.Unit_COUNT,
}
MetaPreServeBytesIn = metric.Metadata{
Name: "sql.pre_serve.bytesin",
Help: "Number of SQL bytes received prior to routing the connection to a specific tenant",
Help: "Number of SQL bytes received prior to routing the connection to the target SQL server",
Measurement: "SQL Bytes",
Unit: metric.Unit_BYTES,
}
MetaPreServeBytesOut = metric.Metadata{
Name: "sql.pre_serve.bytesout",
Help: "Number of SQL bytes sent prior to routing the connection to a specific tenant",
Help: "Number of SQL bytes sent prior to routing the connection to the target SQL server",
Measurement: "SQL Bytes",
Unit: metric.Unit_BYTES,
}
MetaPreServeConnFailures = metric.Metadata{
Name: "sql.pre_serve.conn.failures",
Help: "Number of SQL connection failures prior to routing the connection to a specific tenant",
Help: "Number of SQL connection failures prior to routing the connection to the target SQL server",
Measurement: "Connections",
Unit: metric.Unit_COUNT,
}
MetaPreServeMaxBytes = metric.Metadata{
Name: "sql.pre_serve.mem.max",
Help: "Memory usage for SQL connections prior to routing the connection to a specific tenant",
Help: "Memory usage for SQL connections prior to routing the connection to the target SQL server",
Measurement: "Memory",
Unit: metric.Unit_BYTES,
}
MetaPreServeCurBytes = metric.Metadata{
Name: "sql.pre_serve.mem.cur",
Help: "Current memory usage for SQL connections prior to routing the connection to a specific tenant",
Help: "Current memory usage for SQL connections prior to routing the connection to the target SQL server",
Measurement: "Memory",
Unit: metric.Unit_BYTES,
}
Expand Down
8 changes: 4 additions & 4 deletions pkg/sql/pgwire/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ var (
}
MetaNewConns = metric.Metadata{
Name: "sql.new_conns",
Help: "Counter of the number of SQL connections created",
Help: "Number of SQL connections created",
Measurement: "Connections",
Unit: metric.Unit_COUNT,
}
Expand Down Expand Up @@ -149,19 +149,19 @@ var (
}
MetaPGWireCancelTotal = metric.Metadata{
Name: "sql.pgwire_cancel.total",
Help: "Counter of the number of pgwire query cancel requests",
Help: "Number of pgwire query cancel requests",
Measurement: "Requests",
Unit: metric.Unit_COUNT,
}
MetaPGWireCancelIgnored = metric.Metadata{
Name: "sql.pgwire_cancel.ignored",
Help: "Counter of the number of pgwire query cancel requests that were ignored due to rate limiting",
Help: "Number of pgwire query cancel requests that were ignored due to rate limiting",
Measurement: "Requests",
Unit: metric.Unit_COUNT,
}
MetaPGWireCancelSuccessful = metric.Metadata{
Name: "sql.pgwire_cancel.successful",
Help: "Counter of the number of pgwire query cancel requests that were successful",
Help: "Number of pgwire query cancel requests that were successful",
Measurement: "Requests",
Unit: metric.Unit_COUNT,
}
Expand Down