pgwire: avoid mentioning "tenants" in pre-serve metric descriptions #109076
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
knz
changed the title
pkg/sql/pgwire/pre_serve.go
Outdated
| Measurement: "Memory", | ||
| Unit: metric.Unit_BYTES, | ||
| } | ||
| MetaPreServeCurBytes = metric.Metadata{ | ||
| Name: "sql.pre_serve.mem.cur", | ||
| Help: "Current memory usage for SQL connections prior to routing the connection to a specific tenant", | ||
| Help: "Current memory usage for SQL connections prior to routing the connectionto the target SQL server", |
There was a problem hiding this comment.
| Help: "Current memory usage for SQL connections prior to routing the connectionto the target SQL server", | |
| Help: "Current memory usage for SQL connections prior to routing the connection to the target SQL server", |
There was a problem hiding this comment.
Looks like this one slipped through still.
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @stevendanna and @yuzefovich)
pkg/sql/pgwire/pre_serve.go line 42 at r1 (raw file):
Previously, stevendanna (Steven Danna) wrote…
For consistency with the others, you could do:
Help: "Number of SQL connections created prior to routing the connection to the target SQL server",
Done.
pkg/sql/pgwire/pre_serve.go line 48 at r1 (raw file):
Previously, stevendanna (Steven Danna) wrote…
Help: "Number of SQL bytes received prior to routing the connection to the target SQL server",
Done.
pkg/sql/pgwire/pre_serve.go line 54 at r1 (raw file):
Previously, stevendanna (Steven Danna) wrote…
Help: "Number of SQL bytes sent prior to routing the connection to the target SQL server",
Done.
pkg/sql/pgwire/pre_serve.go line 60 at r1 (raw file):
Previously, stevendanna (Steven Danna) wrote…
Help: "Number of SQL connection failures prior to routing the connection to the target SQL server",
Done.
pkg/sql/pgwire/pre_serve.go line 66 at r1 (raw file):
Previously, stevendanna (Steven Danna) wrote…
Help: "Memory usage for SQL connections prior to routing the connection to the target SQL server",
Done.
pkg/sql/pgwire/pre_serve.go line 72 at r1 (raw file):
Previously, stevendanna (Steven Danna) wrote…
Help: "Current memory usage for SQL connections prior to routing the connection to the target SQL server",
Done.
knz
force-pushed
the
20230819-rename-metrics
branch
from
045ec15 to
34159b7
Compare
Release note: None
There was a problem hiding this comment.
Reviewable status:
pkg/sql/pgwire/pre_serve.go line 72 at r1 (raw file):
Previously, stevendanna (Steven Danna) wrote…
Looks like this one slipped through still.
Indeed. Fixed.
knz
force-pushed
the
20230819-rename-metrics
branch
from
34159b7 to
8a26dee
Compare
|
TFYR! bors r=stevendanna |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error setting reviewers, but backport branch blathers/backport-release-23.1-109076 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/109122/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. [] Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Found via #109042.
Epic: CRDB-29380
Release note: None