builtins: fix recently introduced bitmask fns with mixed type arguments #109043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`FnOverload` is a function that takes in three arguments, and we incorrectly had functions that take four leading to an internal error in case of mixed-type arguments. Release note: None
|
This change is |
rharding6373
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained
|
Thanks for the quick review! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FnOverloadis a function that takes in three arguments, and we incorrectly had functions that take four leading to an internal error in case of mixed-type arguments.Fixes: #108976.
Release note: None