Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/tests: TestRandomSyntaxFunctions failed [panic in bitmask_and] #108976

Closed
cockroach-teamcity opened this issue Aug 18, 2023 · 1 comment · Fixed by #109043
Closed

sql/tests: TestRandomSyntaxFunctions failed [panic in bitmask_and] #108976

cockroach-teamcity opened this issue Aug 18, 2023 · 1 comment · Fixed by #109043
Assignees
@yuzefovich
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). db-cy-23 O-robot Originated from a bot. O-rsg Random Syntax Generator T-sql-queries SQL Queries Team
Milestone
23.2

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Aug 18, 2023 •
edited by cockroach-jira-scripts
Loading

sql/tests.TestRandomSyntaxFunctions failed with artifacts on master @ efa3cfa5574d67640ad58d8437a259edd61dbf40:

Random syntax error:

    rsg_test.go:878: Crash detected: server panic: pq: internal error: interface conversion: tree.FnOverload is func(context.Context, *eval.Context, *tree.DBitArray, string) (tree.Datum, error), not func(context.Context, *eval.Context, tree.Datums) (tree.Datum, error)

Query:

        SELECT bitmask_and(B'1101011110000011000110110011010101111110100010010100100101001000111111101000101011001111010110111', e'\x15\x0eQr':::STRING) ;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

/cc @cockroachdb/sql-foundations

This test on roachdash | Improve this report!

Jira issue: CRDB-30727
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Aug 18, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.2 milestone Aug 18, 2023
@fqazi fqazi added the T-sql-queries SQL Queries Team label Aug 18, 2023
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Aug 18, 2023
@fqazi
Copy link
Collaborator

fqazi commented Aug 18, 2023

Can sql-queries take a look this is linked to #107863

@rafiss rafiss changed the title sql/tests: TestRandomSyntaxFunctions failed sql/tests: TestRandomSyntaxFunctions failed [panic in bitmask_and] Aug 18, 2023
@rafiss rafiss removed the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Aug 18, 2023
@yuzefovich yuzefovich mentioned this issue Aug 18, 2023
Closed
@yuzefovich yuzefovich self-assigned this Aug 18, 2023
@yuzefovich yuzefovich moved this from Triage to Active in SQL Queries Aug 18, 2023
@yuzefovich yuzefovich mentioned this issue Aug 18, 2023
Merged
@craig craig bot closed this as completed in 82b2b95 Aug 18, 2023
@github-project-automation github-project-automation bot moved this from Active to Done in SQL Queries Aug 18, 2023
yuzefovich added a commit to yuzefovich/cockroach that referenced this issue Aug 19, 2023
@yuzefovich
builtins: unify and expand sanity checks of builtins
7042de1 
This commit unifies all sanity checks performed on the builtin overloads
to be in a single place. These checks verify that the correct "function"
fields are set based on the class of the overload.

It additionally introduces an extra check that `Fn` field has the
correct signature (all other fields are verified at compile time via
marker interfaces, but there are just too many `Fn` usages, so it's
easier to have init time check). This check would have prevented cockroachdb#108976
from slipping in.

Epic: None

Release note: None
@yuzefovich yuzefovich mentioned this issue Aug 19, 2023
Merged
yuzefovich added a commit to yuzefovich/cockroach that referenced this issue Aug 22, 2023
@yuzefovich
builtins: unify and expand sanity checks of builtins
1e6dba4 
This commit unifies all sanity checks performed on the builtin overloads
to be in a single place. These checks verify that the correct "function"
fields are set based on the class of the overload.

It additionally introduces an extra check that `Fn` field has the
correct signature (all other fields are verified at compile time via
marker interfaces, but there are just too many `Fn` usages, so it's
easier to have init time check). This check would have prevented cockroachdb#108976
from slipping in.

Epic: None

Release note: None
craig bot pushed a commit that referenced this issue Aug 22, 2023
@yuzefovich
Merge #109066
c4675d3 
109066: builtins: unify and expand sanity checks of builtins r=yuzefovich a=yuzefovich

This commit unifies all sanity checks performed on the builtin overloads to be in a single place. These checks verify that the correct "function" fields are set based on the class of the overload.

It additionally introduces an extra check that `Fn` field has the correct signature (all other fields are verified at compile time via marker interfaces, but there are just too many `Fn` usages, so it's easier to have init time check). This check would have prevented #108976 from slipping in.

Epic: None

Release note: None

Co-authored-by: Yahor Yuzefovich <[email protected]>
@michae2 michae2 added the O-rsg Random Syntax Generator label Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuzefovich yuzefovich

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). db-cy-23 O-robot Originated from a bot. O-rsg Random Syntax Generator T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
23.2
Development

Successfully merging a pull request may close this issue.

builtins: fix recently introduced bitmask fns with mixed type arguments yuzefovich/cockroach
5 participants
@rafiss @fqazi @yuzefovich @cockroach-teamcity @michae2