Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: build: update aws-cli #108794

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

renatolabs
Copy link
Contributor

@renatolabs renatolabs commented Aug 15, 2023

Backport 1/1 commits from #108744.

/cc @cockroachdb/release


The version being previously used was quite old, and didn't support setting the Throughput parameter on gp3 volumes.

See: #108629 (comment).

This commit also brings in changes from master to the Dockerfile for
the builder and bazelbuilder images, so that the image tags
included in the version files match what was actually used to build
them.

Epic: none

Release note: None

Release justification: test-only changes.

The version being previously used was quite old, and didn't support
setting the `Throughput` parameter on `gp3` volumes.

See: cockroachdb#108629 (comment).

This commit also brings in changes from master to the Dockerfile for
the `builder` and `bazelbuilder` images, so that the image tags
included in the version files match what was actually used to build
them.

Epic: none

Release note: None
@renatolabs renatolabs requested a review from a team as a code owner August 15, 2023 18:04
@renatolabs renatolabs requested a review from rail August 15, 2023 18:04
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl
Copy link

blathers-crl bot commented Aug 15, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@renatolabs renatolabs merged commit eb4800c into cockroachdb:release-23.1 Aug 15, 2023
@renatolabs renatolabs deleted the backport23.1-108744 branch August 15, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants