Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update aws-cli #108744

Merged
merged 1 commit into from
Aug 15, 2023
Merged

build: update aws-cli #108744

merged 1 commit into from
Aug 15, 2023

Conversation

renatolabs
Copy link
Contributor

The version being previously used was quite old, and didn't support setting the Throughput parameter on gp3 volumes.

See: #108629 (comment).

Epic: none

Release note: None

@renatolabs renatolabs requested review from pav-kv and a team August 14, 2023 21:29
@renatolabs renatolabs requested a review from a team as a code owner August 14, 2023 21:29
@renatolabs renatolabs requested review from rachitgsrivastava and DarrylWong and removed request for a team August 14, 2023 21:29
@cockroach-teamcity
Copy link
Member

This change is Reviewable

pav-kv
pav-kv approved these changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@pav-kv pav-kv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@srosenberg srosenberg self-requested a review August 15, 2023 01:39
srosenberg
srosenberg approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@srosenberg srosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Methinks both the docker container and build/.bazelbuilderversion need to be updated. build/README.md has manual steps but I see that we now have TC jobs that automate it; please check with #dev-infra.

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @DarrylWong and @rachitgsrivastava)

herkolategan
herkolategan approved these changes Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@herkolategan herkolategan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for fixing this!

@renatolabs
build: update aws-cli
e2065a2 
The version being previously used was quite old, and didn't support
setting the `Throughput` parameter on `gp3` volumes.

See: cockroachdb#108629 (comment).

Epic: none

Release note: None
@renatolabs
Copy link
Contributor Author

TFTRs!

bors r=pavelkalinnikov,srosenberg,herkolategan,rail

@renatolabs renatolabs added the backport-23.1.x Flags PRs that need to be backported to 23.1 label Aug 15, 2023
@craig craig bot merged commit 8ebc6f1 into cockroachdb:master Aug 15, 2023
@craig
Copy link
Contributor

craig bot commented Aug 15, 2023

Build succeeded:

@blathers-crl
Copy link

blathers-crl bot commented Aug 15, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

error creating merge commit from e2065a2 to blathers/backport-release-23.1-108744: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@renatolabs renatolabs mentioned this pull request Aug 15, 2023
Merged
@renatolabs renatolabs deleted the rc/update-aws-cli branch August 21, 2023 14:59
@renatolabs renatolabs mentioned this pull request Aug 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pav-kv pav-kv pav-kv approved these changes

@srosenberg srosenberg srosenberg approved these changes

@herkolategan herkolategan herkolategan approved these changes

@rail rail rail approved these changes

@rachitgsrivastava rachitgsrivastava Awaiting requested review from rachitgsrivastava rachitgsrivastava was automatically assigned from cockroachdb/test-eng

@DarrylWong DarrylWong Awaiting requested review from DarrylWong DarrylWong was automatically assigned from cockroachdb/test-eng

Assignees
No one assigned
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@renatolabs @cockroach-teamcity @rail @herkolategan @srosenberg @pav-kv