Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: make TestScatterResponse work with secondary tenants #108765

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

knz
Copy link
Contributor

@knz knz commented Aug 15, 2023

First two commits from #108764
Informs #76378.
Epic: CRDB-18499

@knz knz requested a review from yuzefovich August 15, 2023 11:25
@knz knz requested review from a team as code owners August 15, 2023 11:25
@knz knz requested review from rachitgsrivastava and DarrylWong and removed request for a team August 15, 2023 11:25
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz force-pushed the 20230815-scatter-response branch from c1f41bb to 6f59585 Compare August 15, 2023 11:36
@knz knz requested a review from a team as a code owner August 15, 2023 11:36
@knz knz force-pushed the 20230815-scatter-response branch 2 times, most recently from 7bc4eb6 to 3b49761 Compare August 15, 2023 12:12
@knz knz requested a review from a team as a code owner August 15, 2023 12:12
@knz knz requested a review from a team August 15, 2023 12:12
Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @DarrylWong and @rachitgsrivastava)

@knz knz force-pushed the 20230815-scatter-response branch from 3b49761 to cebb8ba Compare August 15, 2023 16:43
@knz
Copy link
Contributor Author

knz commented Aug 15, 2023

bors r=yuzefovich

@craig
Copy link
Contributor

craig bot commented Aug 15, 2023

Build succeeded:

@craig craig bot merged commit 8ebc6f1 into cockroachdb:master Aug 15, 2023
@knz knz deleted the 20230815-scatter-response branch August 15, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants