sql/physicalplan: make more tests compatible with secondary tenants #108764
Conversation
knz
requested review from
rachitgsrivastava and
DarrylWong
and removed request for
a team
|
This change is |
knz
force-pushed
the
20230815-phy-plan-tests
branch
from
393d08d to
39e70a3
Compare
knz
force-pushed
the
20230815-phy-plan-tests
branch
2 times, most recently
from
0173582 to
371c1c5
Compare
There was a problem hiding this comment.
The general changes and the ones from sql_stats:
I will leave the kv, multiregion and plans changes to be reviewed by their respective teams
Reviewed 7 of 7 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @DarrylWong, @rachitgsrivastava, and @yuzefovich)
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status:
pkg/server/testserver.go line 1689 at r1 (raw file):
} // LocalityRef is part of the serverutils.StorageLayerInterface.
nit: do we still need this method? I don't see any renaming in the first commit, so it looks like it's actually no longer used. Also, it's now removed from the storage layer interface.
Release note: None
Release note: None
knz
force-pushed
the
20230815-phy-plan-tests
branch
from
371c1c5 to
9c30b09
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/server/testserver.go line 1689 at r1 (raw file):
Previously, yuzefovich (Yahor Yuzefovich) wrote…
nit: do we still need this method? I don't see any renaming in the first commit, so it looks like it's actually no longer used. Also, it's now removed from the storage layer interface.
Good call. Removed.
|
TFYRs bors r=maryliag,yuzefovich |
|
Build succeeded: |
Informs #76378.
Links to #108763.
Epic: CRDB-18499