Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awsdms: use custom status checker #108514

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

Jeremyyang920
Copy link
Collaborator

This commit switches the dms test to use a custom
status checker instead of the one from the SDK. The way the SDK checks for status changes has a likely chance of a race condition which causes it to return an error when there is really no error.

We now use a custom method to do the status checks which does an explicit status check each time the describe task api is called so we are always checking the latest result compared to the way the sdk was doing it.

Fixes: #108270
Release note: None

@Jeremyyang920 Jeremyyang920 requested a review from otan August 10, 2023 14:31
@Jeremyyang920 Jeremyyang920 requested a review from a team as a code owner August 10, 2023 14:31
@Jeremyyang920 Jeremyyang920 requested review from rachitgsrivastava and DarrylWong and removed request for a team August 10, 2023 14:31
@cockroach-teamcity
Copy link
Member

This change is Reviewable

This commit switches the dms test to use a custom
status checker instead of the one from the SDK. The
way the SDK checks for status changes has a likely
chance of a race condition which causes it to return an
error when there is really no error.

We now use a custom method to do the status checks which
does an explicit status check each time the describe task
api is called so we are always checking the latest result
compared to the way the sdk was doing it.

Fixes: cockroachdb#108270
Release note: None
@otan otan added backport-22.2.x backport-23.1.x Flags PRs that need to be backported to 23.1 labels Aug 10, 2023
@Jeremyyang920
Copy link
Collaborator Author

bors r=otan

@craig
Copy link
Contributor

craig bot commented Aug 11, 2023

Build succeeded:

@craig craig bot merged commit 6fa90e9 into cockroachdb:master Aug 11, 2023
@blathers-crl
Copy link

blathers-crl bot commented Aug 11, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from af2dc5a to blathers/backport-release-22.2-108514: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: awsdms failed
3 participants