Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: awsdms failed #108270

Closed
cockroach-teamcity opened this issue Aug 7, 2023 · 0 comments · Fixed by #108514
Closed

roachtest: awsdms failed #108270

cockroach-teamcity opened this issue Aug 7, 2023 · 0 comments · Fixed by #108514
Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-migrations
Milestone
23.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Aug 7, 2023 •
edited by cockroach-jira-scripts
Loading

roachtest.awsdms failed with artifacts on release-23.1 @ aad4fd4312460e6689f543eaff85b1bca8cebf91:

(awsdms.go:285).runAWSDMS: failed to set up AWS DMS: waiter state transitioned to Failure
test artifacts and logs in: /artifacts/awsdms/run_1

Parameters: ROACHTEST_arch=amd64 , ROACHTEST_cloud=aws , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=true , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

/cc @cockroachdb/migrations

This test on roachdash | Improve this report!

Jira issue: CRDB-30403
@cockroach-teamcity cockroach-teamcity added branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-migrations labels Aug 7, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Aug 7, 2023
@Jeremyyang920 Jeremyyang920 mentioned this issue Aug 10, 2023
Merged
@otan otan removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Aug 10, 2023
craig bot pushed a commit that referenced this issue Aug 11, 2023
@Jeremyyang920
Merge #108514
6fa90e9 
108514: awsdms: use custom status checker r=otan a=Jeremyyang920

This commit switches the dms test to use a custom
status checker instead of the one from the SDK. The way the SDK checks for status changes has a likely chance of a race condition which causes it to return an error when there is really no error.

We now use a custom method to do the status checks which does an explicit status check each time the describe task api is called so we are always checking the latest result compared to the way the sdk was doing it.

Fixes: #108270
Release note: None

Co-authored-by: Jeremy Yang <[email protected]>
@craig craig bot closed this as completed in af2dc5a Aug 11, 2023
@blathers-crl blathers-crl bot mentioned this issue Aug 11, 2023
Merged
blathers-crl bot pushed a commit that referenced this issue Aug 11, 2023
@Jeremyyang920
awsdms: use custom status checker
89e1160 
This commit switches the dms test to use a custom
status checker instead of the one from the SDK. The
way the SDK checks for status changes has a likely
chance of a race condition which causes it to return an
error when there is really no error.

We now use a custom method to do the status checks which
does an explicit status check each time the describe task
api is called so we are always checking the latest result
compared to the way the sdk was doing it.

Fixes: #108270
Release note: None
@Jeremyyang920 Jeremyyang920 mentioned this issue Aug 14, 2023
Merged
Jeremyyang920 added a commit that referenced this issue Aug 15, 2023
@Jeremyyang920
awsdms: use custom status checker
dc681c9 
This commit switches the dms test to use a custom
status checker instead of the one from the SDK. The
way the SDK checks for status changes has a likely
chance of a race condition which causes it to return an
error when there is really no error.

We now use a custom method to do the status checks which
does an explicit status check each time the describe task
api is called so we are always checking the latest result
compared to the way the sdk was doing it.

Fixes: #108270
Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-migrations
Projects
None yet
Milestone
23.1
Development

Successfully merging a pull request may close this issue.

awsdms: use custom status checker Jeremyyang920/cockroach
2 participants
@otan @cockroach-teamcity