Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importer: fix stale comment on mysqlStrToDatum #108341

Merged
merged 1 commit into from
Aug 8, 2023
Merged

importer: fix stale comment on mysqlStrToDatum #108341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pkg/sql/importer/read_import_mysql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,10 @@ const (
func mysqlStrToDatum(evalCtx *eval.Context, s string, desired *types.T) (tree.Datum, error) {
switch desired.Family() {
case types.BytesFamily:
// mysql emits raw byte strings that do not use the same escaping as our ParseBytes
// function expects, and the difference between ParseStringAs and
// ParseDatumStringAs is whether or not it attempts to parse bytes.
// mysql emits raw byte strings that do not use the same escaping as our
// tree.ParseDBytes function expects, and the difference between
// tree.ParseAndRequireString and mysqlStrToDatum is whether or not it
// attempts to parse bytes.
return tree.NewDBytes(tree.DBytes(s)), nil
default:
res, _, err := tree.ParseAndRequireString(desired, s, evalCtx)
Expand Down