Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importer: fix stale comment on mysqlStrToDatum #108341

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

otan
Copy link
Contributor

@otan otan commented Aug 7, 2023

Release note: None
Epic: None

From #108286 (review)

Release note: None
Epic: None
@otan otan requested a review from DrewKimball August 7, 2023 23:49
@otan otan requested a review from a team as a code owner August 7, 2023 23:49
@blathers-crl
Copy link

blathers-crl bot commented Aug 7, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@DrewKimball DrewKimball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @otan)

@otan
Copy link
Contributor Author

otan commented Aug 8, 2023

bors r=mgartner,DrewKimball

@craig
Copy link
Contributor

craig bot commented Aug 8, 2023

Build succeeded:

@craig craig bot merged commit 69bc4c6 into cockroachdb:master Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants