sqlccl: test prepared statement in session migration test #108305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
yuzefovich
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @ecwall and @jaylim-crl)
rafiss
force-pushed
the
session-migration-prep-stmt
branch
from
76ad4c7 to
1f2738c
Compare
|
Yeah, UDTs worked in the simple test I made. I updated the PR now. |
rafiss
force-pushed
the
session-migration-prep-stmt
branch
from
1f2738c to
7ebca5e
Compare
ecwall
reviewed
Aug 7, 2023
| @@ -20,6 +20,7 @@ import ( | |||
| "github.com/cockroachdb/cockroach/pkg/testutils/serverutils" | |||
| "github.com/cockroachdb/cockroach/pkg/testutils/sqlutils" | |||
| "github.com/cockroachdb/cockroach/pkg/util/leaktest" | |||
| "github.com/jackc/pgx/v4" | |||
There was a problem hiding this comment.
Can you use v5 or is v4 required for this test?
rafiss
force-pushed
the
session-migration-prep-stmt
branch
from
7ebca5e to
c0867be
Compare
|
tftr bors r+ |
|
Build failed: |
Release note: None
rafiss
force-pushed
the
session-migration-prep-stmt
branch
from
c0867be to
70adada
Compare
|
bors r+ |
|
This PR was included in a batch that timed out, it will be automatically retried |
|
Build succeeded: |
craig bot
pushed a commit
that referenced
this pull request
Aug 10, 2023
108179: concurrency: use lock modes to detect conflicts during optimistic eval r=nvanbenschoten a=arulajmani This patch switches over conflict resolution performed by optimistic evaluation to use lock modes instead of ad-hoc logic. As a result of this, optimistic evaluation is able to handle shared locks. We add a test to show this. Closes #108142 Release note: None 108503: sql: do not evaluate AOST timestamp in session migrations r=rafiss a=rafiss fixes https://github.com/cockroachlabs/support/issues/2510 refs #108305 Release note (bug fix): Fixed a bug where a session migration performed by SHOW TRANSFER STATE would not handle prepared statements that used the AS OF SYSTEM TIME clause. Users who encountered this bug would see errors such as `expected 1 or 0 for number of format codes, got N`. This bug was present since v22.2.0. 108523: roachtest: Reset job load attempt when loading cdc job r=miretskiy a=miretskiy Fixes #108433 Release note: None Co-authored-by: Arul Ajmani <[email protected]> Co-authored-by: Rafi Shamim <[email protected]> Co-authored-by: Yevgeniy Miretskiy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are other tests in pkg/sql/testdata/session_migration but the one in this PR is a full integration test.
informs https://github.com/cockroachlabs/support/issues/2510
Release note: None