concurrency: optimistic evaluation does not make use of lock modes

[arulajmani]

Describe the problem

Optimistic evaluation performs conflict resolution post evaluation, using CheckOptimisticNoConflicts. Eventually, this function finds itself in isNonConflictingLock, which does not use lock modes to check for conflicts:

cockroach/pkg/kv/kvserver/concurrency/lock_table.go

Lines 2362 to 2371 in dc28e19

	func (l *lockState) isNonConflictingLock(g *lockTableGuardImpl, str lock.Strength) bool {
	l.mu.Lock()
	defer l.mu.Unlock()
	// It is possible that this lock is empty and has not yet been deleted.
	if l.isEmptyLock() {
	return true
	}
	// Lock is not empty.
	lockHolderTxn, lockHolderTS := l.getLockHolder()

It should.

Jira issue: CRDB-30327