testutils: return predecessor history from least to most recent #106718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cockroachdb#105231, the order returned by the predecessor history function was inadvertently changed: instead of returning a slice from oldest to newest release, the order was instead reversed (newest to oldest). That breaks the (currently only) caller of `PredecessorHistory` with a parameter greater than 1: `tpcc/mixed-headroom/multiple-upgrades`. As a result, it would attempt an impossible upgrade path from a 23.1 release to a 22.2 release. This commit fixes the API by returning the release histories from oldest to newest as expected, as this is the more sensible API. Fixes: cockroachdb#106716 Release note: None
|
This change is |
renatolabs
requested review from
a team,
srosenberg and
smg260
and removed request for
a team
srosenberg
approved these changes
Jul 12, 2023
|
TFTR! bors r=srosenberg |
|
Build succeeded: |
This was referenced Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #105231, the order returned by the predecessor history function was inadvertently changed: instead of returning a slice from oldest to newest release, the order was instead reversed (newest to oldest).
That breaks the (currently only) caller of
PredecessorHistorywith a parameter greater than 1:tpcc/mixed-headroom/multiple-upgrades. As a result, it would attempt an impossible upgrade path from a 23.1 release to a 22.2 release.This commit fixes the API by returning the release histories from oldest to newest as expected, as this is the more sensible API.
Fixes: #106716
Release note: None