Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: tpcc/mixed-headroom/multiple-upgrades/n5cpu16 failed #106716

Closed
cockroach-teamcity opened this issue Jul 12, 2023 · 1 comment · Fixed by #106718
Closed

roachtest: tpcc/mixed-headroom/multiple-upgrades/n5cpu16 failed #106716

cockroach-teamcity opened this issue Jul 12, 2023 · 1 comment · Fixed by #106718
Labels
branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-testeng TestEng Team
Milestone
23.2

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jul 12, 2023 •
edited by cockroach-jira-scripts
Loading

roachtest.tpcc/mixed-headroom/multiple-upgrades/n5cpu16 failed with artifacts on master @ a6dbdee0e07325f58a8baf30c199c9cf7ad46614:

(versionupgrade.go:287).func1: ~ ./cockroach.sh
�[0;1;31mJob for cockroach.service failed because the control process exited with error code.�[0m
�[0;1;31mSee "systemctl status cockroach.service" and "journalctl -xe" for details.�[0m: COMMAND_PROBLEM: exit status 1
(test_runner.go:1122).func1: 1 dead node(s) detected
test artifacts and logs in: /artifacts/tpcc/mixed-headroom/multiple-upgrades/n5cpu16/run_1

Parameters: ROACHTEST_arch=amd64 , ROACHTEST_cloud=gce , ROACHTEST_cpu=16 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=true , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

/cc @cockroachdb/test-eng

This test on roachdash | Improve this report!

Jira issue: CRDB-29690
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-testeng TestEng Team labels Jul 12, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.2 milestone Jul 12, 2023
@renatolabs renatolabs removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Jul 12, 2023
@renatolabs
Copy link
Contributor

😢

@renatolabs renatolabs mentioned this issue Jul 12, 2023
Merged
craig bot pushed a commit that referenced this issue Jul 13, 2023
@renatolabs
Merge #106718
bbfe3d0 
106718: testutils: return predecessor history from least to most recent r=srosenberg a=renatolabs

In #105231, the order returned by the predecessor history function was inadvertently changed: instead of returning a slice from oldest to newest release, the order was instead reversed (newest to oldest).

That breaks the (currently only) caller of `PredecessorHistory` with a parameter greater than 1: `tpcc/mixed-headroom/multiple-upgrades`. As a result, it would attempt an impossible upgrade path from a 23.1 release to a 22.2 release.

This commit fixes the API by returning the release histories from oldest to newest as expected, as this is the more sensible API.

Fixes: #106716

Release note: None

Co-authored-by: Renato Costa <[email protected]>
@craig craig bot closed this as completed in 347f273 Jul 13, 2023
renatolabs added a commit to renatolabs/cockroach that referenced this issue Jul 17, 2023
@renatolabs
testutils: return predecessor history from least to most recent
11376c3 
In cockroachdb#105231, the order returned by the predecessor history function was
inadvertently changed: instead of returning a slice from oldest to
newest release, the order was instead reversed (newest to oldest).

That breaks the (currently only) caller of `PredecessorHistory` with a
parameter greater than 1: `tpcc/mixed-headroom/multiple-upgrades`. As
a result, it would attempt an impossible upgrade path from a 23.1
release to a 22.2 release.

This commit fixes the API by returning the release histories from
oldest to newest as expected, as this is the more sensible API.

Fixes: cockroachdb#106716

Release note: None
@srosenberg srosenberg added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-testeng TestEng Team
Projects
None yet
Milestone
23.2
Development

Successfully merging a pull request may close this issue.

testutils: return predecessor history from least to most recent renatolabs/cockroach
3 participants
@srosenberg @cockroach-teamcity @renatolabs