Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: statusccl: unskip testTenantRanges pagination #106640

Merged
merged 1 commit into from
Jul 12, 2023
Merged

release-23.1: statusccl: unskip testTenantRanges pagination #106640

merged 1 commit into from
Jul 12, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jul 11, 2023 •
edited by zachlite
Loading

Backport 1/1 commits from #106631 on behalf of @zachlite.

/cc @cockroachdb/release

This test was mistakenly skipped in #105197, but
the flake was addressed in #99054.

The flake on the 22.2 release branch (tracked in #92382) was not novel, but untreated. I misinterpreted this, and thought the skip on master would be for good measure, not realizing the flake was already treated.

Epic: none
Release note: None

Release justification: Unskip test

@zachlite
statusccl: unskip testTenantRanges pagination
d9b1254 
This test was mistakenly skipped in #105197, but
the flake was addressed in #99054.

The flake on the 22.2 release branch (tracked in #92382) was not novel,
but un-treated. I misinterpreted this, and thought the skip
on master would be for good measure, not realizing the flake was
already treated.

Epic: none
Release note: None
@blathers-crl blathers-crl bot requested a review from a team July 11, 2023 23:10
@blathers-crl blathers-crl bot requested a review from a team as a code owner July 11, 2023 23:10
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-106631 branch 2 times, most recently from 4733b08 to d9b1254 Compare July 11, 2023 23:10
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jul 11, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Jul 11, 2023 •
edited by zachlite
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested a review from xinhaoz July 11, 2023 23:10
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@zachlite zachlite merged commit 36f7ff3 into release-23.1 Jul 12, 2023
@zachlite zachlite deleted the blathers/backport-release-23.1-106631 branch July 12, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinhaoz xinhaoz xinhaoz approved these changes

Assignees

@zachlite zachlite

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @xinhaoz @zachlite