-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statusccl: skip flaky TenantStatusAPI tests #105197
Conversation
a skip "informs", it does not "resolve" - we want the original issues to remain open until the bug has actually been addressed. |
LGTM modulo rephrasing the commit message. |
Ack. Thanks for the drive-by. |
Informs cockroachdb#92382, cockroachdb#99770, cockroachdb#99559 Epic: none Release note: None
dc773a7
to
a2a51bb
Compare
bors r+ |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from a2a51bb to blathers/backport-release-22.2-105197: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. error setting reviewers, but backport branch blathers/backport-release-23.1-105197 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/105202/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. [] Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This test was mistakenly skipped in cockroachdb#105197, but the flake was addressed in cockroachdb#99054. The flake on the 22.2 release branch (tracked in cockroachdb#92382) was not novel, but un-treated. I misinterpreted this, and thought the skip on master would be for good measure, not realizing the flake was already treated. Epic: none Release note: None
106631: statusccl: unskip testTenantRanges pagination r=zachlite a=zachlite This test was mistakenly skipped in #105197, but the flake was addressed in #99054. The flake on the 22.2 release branch (tracked in #92382) was not novel, but untreated. I misinterpreted this, and thought the skip on master would be for good measure, not realizing the flake was already treated. Epic: none Release note: None Co-authored-by: zachlite <[email protected]>
This test was mistakenly skipped in #105197, but the flake was addressed in #99054. The flake on the 22.2 release branch (tracked in #92382) was not novel, but un-treated. I misinterpreted this, and thought the skip on master would be for good measure, not realizing the flake was already treated. Epic: none Release note: None
Informs #92382, #99770, #99559
Epic: none
Release note: None