Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statusccl: skip flaky TenantStatusAPI tests #105197

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

zachlite
Copy link
Contributor

@zachlite zachlite commented Jun 20, 2023

Informs #92382, #99770, #99559
Epic: none
Release note: None

@zachlite zachlite added backport-22.2.x backport-23.1.x Flags PRs that need to be backported to 23.1 labels Jun 20, 2023
@zachlite zachlite requested a review from a team June 20, 2023 14:59
@zachlite zachlite requested a review from a team as a code owner June 20, 2023 14:59
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@zachlite zachlite requested review from maryliag and j82w June 20, 2023 15:01
@knz
Copy link
Contributor

knz commented Jun 20, 2023

a skip "informs", it does not "resolve" - we want the original issues to remain open until the bug has actually been addressed.

@knz
Copy link
Contributor

knz commented Jun 20, 2023

LGTM modulo rephrasing the commit message.

@zachlite
Copy link
Contributor Author

a skip "informs", it does not "resolve" - we want the original issues to remain open until the bug has actually been addressed.

Ack. Thanks for the drive-by.

@zachlite zachlite force-pushed the 230620.skip-flakes branch from dc773a7 to a2a51bb Compare June 20, 2023 15:03
@zachlite
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 20, 2023

Build succeeded:

@craig craig bot merged commit 91f0de4 into cockroachdb:master Jun 20, 2023
@blathers-crl
Copy link

blathers-crl bot commented Jun 20, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from a2a51bb to blathers/backport-release-22.2-105197: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


error setting reviewers, but backport branch blathers/backport-release-23.1-105197 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/105202/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

zachlite added a commit to zachlite/cockroach that referenced this pull request Jul 11, 2023
This test was mistakenly skipped in cockroachdb#105197, but
the flake was addressed in cockroachdb#99054.

The flake on the 22.2 release branch (tracked in cockroachdb#92382) was not novel,
but un-treated. I misinterpreted this, and thought the skip
on master would be for good measure, not realizing the flake was
already treated.

Epic: none
Release note: None
craig bot pushed a commit that referenced this pull request Jul 11, 2023
106631: statusccl: unskip testTenantRanges pagination r=zachlite a=zachlite

This test was mistakenly skipped in #105197, but
the flake was addressed in #99054.

The flake on the 22.2 release branch (tracked in #92382) was not novel, but untreated. I misinterpreted this, and thought the skip on master would be for good measure, not realizing the flake was already treated.

Epic: none
Release note: None

Co-authored-by: zachlite <[email protected]>
blathers-crl bot pushed a commit that referenced this pull request Jul 11, 2023
This test was mistakenly skipped in #105197, but
the flake was addressed in #99054.

The flake on the 22.2 release branch (tracked in #92382) was not novel,
but un-treated. I misinterpreted this, and thought the skip
on master would be for good measure, not realizing the flake was
already treated.

Epic: none
Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants