-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli/zip: Use "cluster" to identify the logical cluster instead of "tenant" #106298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @knz and @Santamaura)
-- commits
line 5 at r1:
nit: maybe s/generated zip/debug zip/
for clarity?
…nant" Release note (cluster virtualization): This patch renames the subdirectory inside the output of `cockroach debug zip` when pointed to a cluster with virtualization enabled to be `cluster`, which brings the UX in coherence with the parameter of the same name in `cockroach sql` and the HTTP API parameter in the same name.
Done |
bors r=yuzefovich |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 61cee9a to blathers/backport-release-23.1-106298: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Informs #106068.
Epic: CRDB-29380
Requested by Abbey Russell in replacement of #106117.
Release note (cluster virtualization): This patch renames the
subdirectory inside the output of
cockroach debug zip
when pointedto a cluster with virtualization enabled to be
cluster
, which bringsthe UX in coherence with the parameter of the same name in
cockroach sql
and the HTTP API parameter in the same name.