cli/zip: emphasize "cluster virtualization" #106117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Closed
15 tasks
Release note (cli change): When `debug zip` is pointed at a multi-tenant cluster or a cluster with virtualization enabled, data about virtual clusters is now stored in a `virtual` sub-directory (this was previously named `tenants`).
knz
force-pushed
the
20230704-debug-zip-tenants
branch
from
5fb055c to
cc1ffa7
Compare
knz
added
A-multitenancy
yuzefovich
approved these changes
Jul 5, 2023
There was a problem hiding this comment.
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @Santamaura and @stevendanna)
|
bors r=yuzefovich |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from cc1ffa7 to blathers/backport-release-23.1-106117: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
craig bot
pushed a commit
that referenced
this pull request
Jul 7, 2023
106298: cli/zip: Use "cluster" to identify the logical cluster instead of "tenant" r=yuzefovich a=knz Informs #106068. Epic: CRDB-29380 Requested by Abbey Russell in replacement of #106117. Release note (cluster virtualization): This patch renames the subdirectory inside the generated zip file to be `cluster`, which brings the UX in coherence with the parameter of the same name in `cockroach sql` and the HTTP API parameter in the same name. Co-authored-by: Raphael 'kena' Poss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #106068.
Epic: CRDB-29380
Release note (cli change): When
debug zipis pointed at a multi-tenant cluster or a cluster with virtualization enabled, data about virtual clusters is now stored in avirtualsub-directory (this was previously namedtenants).