Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testcluster: unskip no longer flaky test #105587

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

yuzefovich
Copy link
Member

TestRestart appears to not be flaky anymore. See #104740 (comment) for more details.

Fixes: #104740.

Release note: None

`TestRestart` appears to not be flaky anymore. See cockroachdb#104740 (comment)
for more details.

Release note: None
@yuzefovich yuzefovich requested review from msbutler, a team and michae2 June 26, 2023 22:14
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)

@yuzefovich
Copy link
Member Author

No failures in over 30 minutes of stressing.

TFTRs!

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 26, 2023

Build succeeded:

@craig craig bot merged commit 961a2e6 into cockroachdb:master Jun 26, 2023
@yuzefovich yuzefovich deleted the unskip-good-test branch June 26, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testutils: TestRestart flaked on master
4 participants