Skip to content

Commit

Permalink
Merge #105587
Browse files Browse the repository at this point in the history
105587: testcluster: unskip no longer flaky test r=yuzefovich a=yuzefovich

`TestRestart` appears to not be flaky anymore. See #104740 (comment) for more details.

Fixes: #104740.

Release note: None

Co-authored-by: Yahor Yuzefovich <[email protected]>
  • Loading branch information
craig[bot] and yuzefovich committed Jun 26, 2023
2 parents 5b9824f + a1bfbd7 commit 961a2e6
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion pkg/testutils/testcluster/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ go_test(
"//pkg/sql/catalog/desctestutils",
"//pkg/testutils",
"//pkg/testutils/serverutils",
"//pkg/testutils/skip",
"//pkg/testutils/sqlutils",
"//pkg/util/httputil",
"//pkg/util/leaktest",
Expand Down
2 changes: 0 additions & 2 deletions pkg/testutils/testcluster/testcluster_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import (
"github.com/cockroachdb/cockroach/pkg/server/serverpb"
"github.com/cockroachdb/cockroach/pkg/sql/catalog/desctestutils"
"github.com/cockroachdb/cockroach/pkg/testutils"
"github.com/cockroachdb/cockroach/pkg/testutils/skip"
"github.com/cockroachdb/cockroach/pkg/testutils/sqlutils"
"github.com/cockroachdb/cockroach/pkg/util/httputil"
"github.com/cockroachdb/cockroach/pkg/util/leaktest"
Expand Down Expand Up @@ -273,7 +272,6 @@ func TestStopServer(t *testing.T) {

func TestRestart(t *testing.T) {
defer leaktest.AfterTest(t)()
skip.WithIssue(t, 104740)

stickyEngineRegistry := server.NewStickyInMemEnginesRegistry()
defer stickyEngineRegistry.CloseAllStickyInMemEngines()
Expand Down

0 comments on commit 961a2e6

Please sign in to comment.