Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: startup: retry pgerror.Code == RangeUnavailable #104250

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

tbg
Copy link
Member

@tbg tbg commented Jun 2, 2023

Backport 1/1 commits from #104128.

/cc @cockroachdb/release

Release justification: bug fix.


Closes #104016.

Epic: None
Release note (bug fix): a bug was fixed due to which nodes could terminate with the following message:
server startup failed: cockroach server exited with error:
‹migration-job-find-already-completed›: key range id:X is unavailable: ‹failed
to send RPC: no replica node information available via gossip for rX›

@blathers-crl
Copy link

blathers-crl bot commented Jun 2, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl
Copy link

blathers-crl bot commented Jun 2, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Closes cockroachdb#104016.

Epic: None
Release note (bug fix): a bug was fixed due to which nodes could terminate with the following message:
    server startup failed: cockroach server exited with error:
    ‹migration-job-find-already-completed›: key range id:X is unavailable: ‹failed
    to send RPC: no replica node information available via gossip for rX›
@tbg tbg force-pushed the backport22.2-104128 branch from 1d10214 to d8bd041 Compare June 2, 2023 11:29
@tbg tbg requested a review from aliher1911 June 2, 2023 11:30
@tbg tbg merged commit 6801c4b into cockroachdb:release-22.2 Jun 2, 2023
@tbg tbg deleted the backport22.2-104128 branch June 2, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants