Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

startup: retry pgerror.Code == RangeUnavailable #104128

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

tbg
Copy link
Member

@tbg tbg commented May 31, 2023

Closes #104016.

Epic: None
Release note (bug fix): a bug was fixed due to which nodes could terminate with the following message:
server startup failed: cockroach server exited with error:
‹migration-job-find-already-completed›: key range id:X is unavailable: ‹failed
to send RPC: no replica node information available via gossip for rX›

Closes cockroachdb#104016.

Epic: None
Release note (bug fix): a bug was fixed due to which nodes could terminate with the following message:
    server startup failed: cockroach server exited with error:
    ‹migration-job-find-already-completed›: key range id:X is unavailable: ‹failed
    to send RPC: no replica node information available via gossip for rX›
@blathers-crl
Copy link

blathers-crl bot commented May 31, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@tbg tbg requested a review from aliher1911 May 31, 2023 08:23
@tbg tbg added backport-22.2.x backport-23.1.x Flags PRs that need to be backported to 23.1 labels May 31, 2023
@tbg tbg marked this pull request as ready for review May 31, 2023 10:04
Copy link
Contributor

@aliher1911 aliher1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that we could easily plug in any error. 😆 😭

@tbg
Copy link
Member Author

tbg commented Jun 2, 2023

TFTR!

bors r=aliher1911

@craig
Copy link
Contributor

craig bot commented Jun 2, 2023

Build succeeded:

@craig craig bot merged commit a3736c3 into cockroachdb:master Jun 2, 2023
@blathers-crl
Copy link

blathers-crl bot commented Jun 2, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from df97a99 to blathers/backport-release-22.2-104128: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: clearrange/checks=false/rangeTs=false failed
3 participants