-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.2: kvserver: improve system lease observability #104077
release-22.2: kvserver: improve system lease observability #104077
Conversation
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Unclean metrics backport (the calcReplicaMetrics bit), but I think I got it right. |
This patch adds the metric `leases.liveness` tracking the number of liveness range leases per node (generally 1 or 0). This is useful to find out which node had the liveness lease at a particular time. I ran a 10k range cluster to look at the CPU cost of the key comparisons, it didn't show up on CPU profiles. Epic: none Release note (ops change): added the metric `leases.liveness` showing the number of liveness range leases per node (generally 1 or 0), to track the liveness range leaseholder.
This patch logs acquisition of meta/liveness range leases to the health log. These leases are critical to cluster health, and during debugging it's useful to know their location over time. Epic: none Release note: None
42ea2df
to
4f274ed
Compare
Backport 2/2 commits from #104008.
/cc @cockroachdb/release
kvserver: add
leases.liveness
metricThis patch adds the metric
leases.liveness
tracking the number of liveness range leases per node (generally 1 or 0). This is useful to find out which node had the liveness lease at a particular time.I ran a 10k range cluster to look at the CPU cost of the key comparisons, it didn't show up on CPU profiles.
Epic: none
Release note (ops change): added the metric
leases.liveness
showing the number of liveness range leases per node (generally 1 or 0), to track the liveness range leaseholder.kvserver: log system range lease acquisition
This patch logs acquisition of meta/liveness range leases to the health log. These leases are critical to cluster health, and during debugging it's useful to know their location over time.
Resolves #99472.
Epic: none
Release note: none