Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: kvserver: improve system lease observability #104077

Merged

Conversation

erikgrinaker
Copy link
Contributor

Backport 2/2 commits from #104008.

/cc @cockroachdb/release


kvserver: add leases.liveness metric

This patch adds the metric leases.liveness tracking the number of liveness range leases per node (generally 1 or 0). This is useful to find out which node had the liveness lease at a particular time.

I ran a 10k range cluster to look at the CPU cost of the key comparisons, it didn't show up on CPU profiles.

Epic: none
Release note (ops change): added the metric leases.liveness showing the number of liveness range leases per node (generally 1 or 0), to track the liveness range leaseholder.

kvserver: log system range lease acquisition

This patch logs acquisition of meta/liveness range leases to the health log. These leases are critical to cluster health, and during debugging it's useful to know their location over time.

Resolves #99472.

Epic: none
Release note: none

@erikgrinaker erikgrinaker requested review from tbg and a team May 30, 2023 13:54
@erikgrinaker erikgrinaker requested a review from a team as a code owner May 30, 2023 13:54
@erikgrinaker erikgrinaker self-assigned this May 30, 2023
@blathers-crl
Copy link

blathers-crl bot commented May 30, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl
Copy link

blathers-crl bot commented May 30, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker
Copy link
Contributor Author

Unclean metrics backport (the calcReplicaMetrics bit), but I think I got it right.

This patch adds the metric `leases.liveness` tracking the number of
liveness range leases per node (generally 1 or 0). This is useful to
find out which node had the liveness lease at a particular time.

I ran a 10k range cluster to look at the CPU cost of the key
comparisons, it didn't show up on CPU profiles.

Epic: none
Release note (ops change): added the metric `leases.liveness` showing
the number of liveness range leases per node (generally 1 or 0), to
track the liveness range leaseholder.
This patch logs acquisition of meta/liveness range leases to the health
log. These leases are critical to cluster health, and during debugging
it's useful to know their location over time.

Epic: none
Release note: None
@erikgrinaker erikgrinaker force-pushed the backport22.2-104008 branch from 42ea2df to 4f274ed Compare June 6, 2023 08:06
@erikgrinaker erikgrinaker requested a review from a team June 6, 2023 08:06
@erikgrinaker erikgrinaker merged commit 0e56ed0 into cockroachdb:release-22.2 Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants