Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: improve system lease observability #104008

Merged
merged 2 commits into from
May 30, 2023

Conversation

erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented May 27, 2023

kvserver: add leases.liveness metric

This patch adds the metric leases.liveness tracking the number of liveness range leases per node (generally 1 or 0). This is useful to find out which node had the liveness lease at a particular time.

I ran a 10k range cluster to look at the CPU cost of the key comparisons, it didn't show up on CPU profiles.

Epic: none
Release note (ops change): added the metric leases.liveness showing the number of liveness range leases per node (generally 1 or 0), to track the liveness range leaseholder.

kvserver: log system range lease acquisition

This patch logs acquisition of meta/liveness range leases to the health log. These leases are critical to cluster health, and during debugging it's useful to know their location over time.

Resolves #99472.

Epic: none
Release note: none

@erikgrinaker erikgrinaker requested a review from tbg May 27, 2023 20:37
@erikgrinaker erikgrinaker self-assigned this May 27, 2023
@erikgrinaker erikgrinaker requested a review from a team May 27, 2023 20:37
@erikgrinaker erikgrinaker requested a review from a team as a code owner May 27, 2023 20:37
@blathers-crl
Copy link

blathers-crl bot commented May 27, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker erikgrinaker added backport-23.1.x Flags PRs that need to be backported to 23.1 backport-22.2.x labels May 27, 2023
This patch adds the metric `leases.liveness` tracking the number of
liveness range leases per node (generally 1 or 0). This is useful to
find out which node had the liveness lease at a particular time.

I ran a 10k range cluster to look at the CPU cost of the key
comparisons, it didn't show up on CPU profiles.

Epic: none
Release note (ops change): added the metric `leases.liveness` showing
the number of liveness range leases per node (generally 1 or 0), to
track the liveness range leaseholder.
This patch logs acquisition of meta/liveness range leases to the health
log. These leases are critical to cluster health, and during debugging
it's useful to know their location over time.

Epic: none
Release note: None
@erikgrinaker erikgrinaker force-pushed the liveness-range-metrics branch from 9e8b8a2 to b9148c7 Compare May 28, 2023 08:10
@erikgrinaker
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented May 30, 2023

Build failed:

@erikgrinaker
Copy link
Contributor Author

bors retry

@craig
Copy link
Contributor

craig bot commented May 30, 2023

Build failed:

@erikgrinaker
Copy link
Contributor Author

bors retry

@craig
Copy link
Contributor

craig bot commented May 30, 2023

Build failed:

@erikgrinaker
Copy link
Contributor Author

bors retry

@craig
Copy link
Contributor

craig bot commented May 30, 2023

Build failed:

@erikgrinaker
Copy link
Contributor Author

Wow, much flake.

bors retry

@craig
Copy link
Contributor

craig bot commented May 30, 2023

Build succeeded:

@craig craig bot merged commit 5ee25de into cockroachdb:master May 30, 2023
@blathers-crl
Copy link

blathers-crl bot commented May 30, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 71117b1 to blathers/backport-release-22.2-104008: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


error creating merge commit from b9148c7 to blathers/backport-release-23.1-104008: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kvserver: metric and logging to pinpoint liveness leaseholder
3 participants