-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kvserver: improve system lease observability #104008
kvserver: improve system lease observability #104008
Conversation
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This patch adds the metric `leases.liveness` tracking the number of liveness range leases per node (generally 1 or 0). This is useful to find out which node had the liveness lease at a particular time. I ran a 10k range cluster to look at the CPU cost of the key comparisons, it didn't show up on CPU profiles. Epic: none Release note (ops change): added the metric `leases.liveness` showing the number of liveness range leases per node (generally 1 or 0), to track the liveness range leaseholder.
This patch logs acquisition of meta/liveness range leases to the health log. These leases are critical to cluster health, and during debugging it's useful to know their location over time. Epic: none Release note: None
9e8b8a2
to
b9148c7
Compare
bors r+ |
Build failed: |
bors retry |
Build failed: |
bors retry |
Build failed: |
bors retry |
Build failed: |
Wow, much flake. bors retry |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 71117b1 to blathers/backport-release-22.2-104008: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. error creating merge commit from b9148c7 to blathers/backport-release-23.1-104008: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
kvserver: add
leases.liveness
metricThis patch adds the metric
leases.liveness
tracking the number of liveness range leases per node (generally 1 or 0). This is useful to find out which node had the liveness lease at a particular time.I ran a 10k range cluster to look at the CPU cost of the key comparisons, it didn't show up on CPU profiles.
Epic: none
Release note (ops change): added the metric
leases.liveness
showing the number of liveness range leases per node (generally 1 or 0), to track the liveness range leaseholder.kvserver: log system range lease acquisition
This patch logs acquisition of meta/liveness range leases to the health log. These leases are critical to cluster health, and during debugging it's useful to know their location over time.
Resolves #99472.
Epic: none
Release note: none