-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: sql: add stats to telemetry sampled query event #103841
Conversation
This adds the MVCC stats, cpu usage, and latency information to the telemetry sampled query event. This is needed to make it match the data available in the system statement_statistics table. Epic: none Closes: #89887 Release note (sql change): Adds the MVCC stats, cpu usage, and latency information to the telemetry sampled query event.
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error setting reviewers, but backport branch blathers/backport-release-23.1-103841 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/103858/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. [] Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Backport 1/1 commits from #102820.
/cc @cockroachdb/release
This adds the MVCC stats, cpu usage, and latency information to the telemetry sampled query event. This is needed to make it match the data available in the system statement_statistics table.
Epic: none
Closes: #89887
Release note (sql change): Adds the MVCC stats, cpu usage, and latency information to the telemetry sampled query event.
Release Justification: Adds required information for troubleshooting.