Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: sql: add stats to telemetry sampled query event #103841

Merged
merged 1 commit into from
May 24, 2023
Merged

release-23.1: sql: add stats to telemetry sampled query event #103841

merged 1 commit into from
May 24, 2023

Conversation

j82w
Copy link
Contributor

@j82w j82w commented May 24, 2023

Backport 1/1 commits from #102820.

/cc @cockroachdb/release


This adds the MVCC stats, cpu usage, and latency information to the telemetry sampled query event. This is needed to make it match the data available in the system statement_statistics table.

Epic: none
Closes: #89887

Release note (sql change): Adds the MVCC stats, cpu usage, and latency information to the telemetry sampled query event.
Release Justification: Adds required information for troubleshooting.

This adds the MVCC stats, cpu usage, and latency information to the
telemetry sampled query event. This is needed to make it match the
data available in the system statement_statistics table.

Epic: none
Closes: #89887

Release note (sql change): Adds the MVCC stats, cpu usage, and latency
information to the telemetry sampled query event.
@j82w j82w requested review from a team May 24, 2023 14:40
@j82w j82w requested a review from a team as a code owner May 24, 2023 14:40
@j82w j82w requested a review from yuzefovich May 24, 2023 14:40
@blathers-crl
Copy link

blathers-crl bot commented May 24, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@j82w j82w added the backport-23.1.x Flags PRs that need to be backported to 23.1 label May 24, 2023
Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)

@blathers-crl
Copy link

blathers-crl bot commented May 24, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error setting reviewers, but backport branch blathers/backport-release-23.1-103841 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/103858/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants