Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect CPU seconds per statement as telemetry data #89887

Closed
kevin-v-ngo opened this issue Oct 13, 2022 · 2 comments · Fixed by #102820
Closed

Collect CPU seconds per statement as telemetry data #89887

kevin-v-ngo opened this issue Oct 13, 2022 · 2 comments · Fixed by #102820
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@kevin-v-ngo
Copy link

kevin-v-ngo commented Oct 13, 2022 •
edited
Loading

This issue tracks collecting CPU seconds per statement in the telemetry channel by enriching the existing query log event.

Epic: CRDB-2457

Jira issue: CRDB-20480
@kevin-v-ngo kevin-v-ngo added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Oct 13, 2022
@maryliag
Copy link
Contributor

Dependent on #87213

@kevin-v-ngo kevin-v-ngo mentioned this issue Jan 13, 2023
Open
@kevin-v-ngo
Copy link
Author

Related PR: #95639

@j82w j82w mentioned this issue May 5, 2023
Merged
craig bot pushed a commit that referenced this issue May 16, 2023
@msbutler @rail
Merge #102820 #103350 #103445
b6087e6 
102820: sql: add stats to telemetry sampled query event r=j82w a=j82w

This adds the MVCC stats, cpu usage, and latency information to the telemetry sampled query event. This is needed to make it match the data available in the system statement_statistics table.

Epic: none
Closes: #89887

Release note (sql change): Adds the MVCC stats, cpu usage, and latency information to the telemetry sampled query event.

103350: c2c: deflake shutdown test during initial scan or cutover r=stevendanna a=msbutler

Previously the c2c shutdown tests that scheduled a node shutdown during an
intitial scan could fail because the initial scan completed too quickly. This
patch 5x's the amount of data ingested during the initial scan to prevent this
failure mode.

This patch also prevents flakes if cutover completes too quickly by lowering
the time the test driver sleeps between when the job enters the cutover phase
and when the node shutdown occurs. The driver also now checks if the ingestion
job has completed before checking the job progress, avoiding a race seen in
issue #103248.

Fixes #103248

Release note: None

103445: release: run preflight on the latest image r=celiala a=rail

Previously, we ran preflight against the versioned image only. As a result the auto-publishing worked only for the versioned image, but not the `latest` tag.

This PR adds a new call to `preflight` against the `latest` image.

Epic: none
Release note: None

Co-authored-by: j82w <[email protected]>
Co-authored-by: Michael Butler <[email protected]>
Co-authored-by: Rail Aliiev <[email protected]>
@craig craig bot closed this as completed in bff2fb6 May 16, 2023
@blathers-crl blathers-crl bot mentioned this issue May 24, 2023
Closed
blathers-crl bot pushed a commit that referenced this issue May 24, 2023
sql: add stats to telemetry sampled query event
cb69f03 
This adds the MVCC stats, cpu usage, and latency information to the
telemetry sampled query event. This is needed to make it match the
data available in the system statement_statistics table.

Epic: none
Closes: #89887

Release note (sql change): Adds the MVCC stats, cpu usage, and latency
information to the telemetry sampled query event.
@j82w j82w mentioned this issue May 24, 2023
Merged
@blathers-crl blathers-crl bot mentioned this issue May 24, 2023
Closed
blathers-crl bot pushed a commit that referenced this issue May 24, 2023
sql: add stats to telemetry sampled query event
9d14aa7 
This adds the MVCC stats, cpu usage, and latency information to the
telemetry sampled query event. This is needed to make it match the
data available in the system statement_statistics table.

Epic: none
Closes: #89887

Release note (sql change): Adds the MVCC stats, cpu usage, and latency
information to the telemetry sampled query event.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: add stats to telemetry sampled query event
2 participants
@maryliag @kevin-v-ngo