release-23.1: pgwire: adds bounds check for FormatCodes #103696
Merged
+16
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #103645 on behalf of @rafiss.
/cc @cockroachdb/release
fixes #103629
Now we check the bounds when looking for the format code to use.
Getting an out of bounds index is not expected, so we use an assertion error. This is less disruptive than a panic that crashes the node.
Release note: None
Release justification: bug fix