Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgwire: adds bounds check for FormatCodes #103645

Merged
merged 1 commit into from
May 20, 2023

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented May 18, 2023

fixes #103629

Now we check the bounds when looking for the format code to use.

Getting an out of bounds index is not expected, so we use an assertion error. This is less disruptive than a panic that crashes the node.

Release note: None

@rafiss rafiss added backport-22.2.x backport-23.1.x Flags PRs that need to be backported to 23.1 labels May 18, 2023
@rafiss rafiss requested a review from yuzefovich May 18, 2023 22:22
@rafiss rafiss requested review from a team as code owners May 18, 2023 22:22
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rafiss)

Now we check the bounds when looking for the format code to use.

Getting an out of bounds index is not expected, so we use an assertion
error. This is less disruptive than a panic that crashes the node.

Release note: None
@rafiss rafiss force-pushed the fix-batch-write-pgwire branch from d8cb354 to dd268d6 Compare May 20, 2023 15:03
@rafiss
Copy link
Collaborator Author

rafiss commented May 20, 2023

tftr!

bors r+

@craig
Copy link
Contributor

craig bot commented May 20, 2023

Build succeeded:

@craig craig bot merged commit b34c137 into cockroachdb:master May 20, 2023
@blathers-crl
Copy link

blathers-crl bot commented May 20, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from dd268d6 to blathers/backport-release-22.2-103645: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


error setting reviewers, but backport branch blathers/backport-release-23.1-103645 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/103696/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@rafiss rafiss deleted the fix-batch-write-pgwire branch May 22, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: v22.2.9: index out of bounds on formatCodes in bufferBatch
4 participants