Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: go.mod: bump Pebble to 9f426d5cfd97 #103315

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented May 15, 2023

9f426d5c Revert "vfs: include size of write in DiskSlowInfo"
949d9808 Revert "vfs: mark file basename as safe to avoid log redaction"

Fixes: #103185
Fixes: #102946
Fixes: #102944
Fixes: #102940
Release note: none
Release justification: Fixes high-severity issue where disk stalls could go undetected.

@jbowens jbowens requested a review from a team May 15, 2023 15:55
@jbowens jbowens requested a review from a team as a code owner May 15, 2023 15:55
@jbowens jbowens requested a review from RaduBerinde May 15, 2023 15:55
@blathers-crl
Copy link

blathers-crl bot commented May 15, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

```
9f426d5c Revert "vfs: include size of write in DiskSlowInfo"
949d9808 Revert "vfs: mark file basename as safe to avoid log redaction"
```

Fixes: cockroachdb#103185
Fixes: cockroachdb#102946
Fixes: cockroachdb#102944
Fixes: cockroachdb#102940
Release note: none
@jbowens jbowens force-pushed the jackson/pebble-release-23.1-9f426d5cfd97 branch from 095069b to d39afea Compare May 15, 2023 15:56
@blathers-crl
Copy link

blathers-crl bot commented May 15, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@nicktrav
Copy link
Collaborator

Shall we decline this in favor of #103339?

@jbowens jbowens closed this May 15, 2023
@jbowens jbowens deleted the jackson/pebble-release-23.1-9f426d5cfd97 branch May 15, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants