Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: disk-stalled/cgroup/read-write/logs-too=true failed #102944

Closed
cockroach-teamcity opened this issue May 9, 2023 · 5 comments
Closed
Assignees
Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-storage Storage Team
Milestone

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented May 9, 2023

roachtest.disk-stalled/cgroup/read-write/logs-too=true failed with artifacts on release-23.1 @ 5376e479204d6e8243f67c30aea3d031df529afd:

test artifacts and logs in: /artifacts/disk-stalled/cgroup/read-write/logs-too=true/run_1
(disk_stall.go:176).runDiskStalledDetection: connection to n1 is still alive
(cluster.go:1981).Run: cluster.RunE: context canceled
(cluster.go:1981).Run: output in run_113507.493921683_n4_cockroach-workload-r: ./cockroach workload run kv --read-percent 50 --duration 10m --concurrency 256 --max-rate 2048 --tolerate-errors  --min-block-bytes=512 --max-block-bytes=512 {pgurl:1-3} returned: context canceled

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=true , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

/cc @cockroachdb/storage

This test on roachdash | Improve this report!

Jira issue: CRDB-27749

@cockroach-teamcity cockroach-teamcity added branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels May 9, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone May 9, 2023
@blathers-crl blathers-crl bot added the T-storage Storage Team label May 9, 2023
@cockroach-teamcity
Copy link
Member Author

roachtest.disk-stalled/cgroup/read-write/logs-too=true failed with artifacts on release-23.1 @ 6c6d6657a21dd94d98e4c99c8d6c64f6353a5774:

test artifacts and logs in: /artifacts/disk-stalled/cgroup/read-write/logs-too=true/run_1
(disk_stall.go:176).runDiskStalledDetection: connection to n1 is still alive
(cluster.go:1981).Run: cluster.RunE: context canceled
(cluster.go:1981).Run: output in run_113934.061791129_n4_cockroach-workload-r: ./cockroach workload run kv --read-percent 50 --duration 10m --concurrency 256 --max-rate 2048 --tolerate-errors  --min-block-bytes=512 --max-block-bytes=512 {pgurl:1-3} returned: context canceled

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=true , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.disk-stalled/cgroup/read-write/logs-too=true failed with artifacts on release-23.1 @ 6ceddbd9dc6b987add91ea93a665088e7928cb88:

test artifacts and logs in: /artifacts/disk-stalled/cgroup/read-write/logs-too=true/run_1
(disk_stall.go:176).runDiskStalledDetection: connection to n1 is still alive
(cluster.go:1981).Run: cluster.RunE: context canceled
(cluster.go:1981).Run: output in run_121229.583435736_n4_cockroach-workload-r: ./cockroach workload run kv --read-percent 50 --duration 10m --concurrency 256 --max-rate 2048 --tolerate-errors  --min-block-bytes=512 --max-block-bytes=512 {pgurl:1-3} returned: context canceled

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=true , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.disk-stalled/cgroup/read-write/logs-too=true failed with artifacts on release-23.1 @ bc953426b8cc479406c3b54b99154eb15fa4107b:

test artifacts and logs in: /artifacts/disk-stalled/cgroup/read-write/logs-too=true/run_1
(disk_stall.go:176).runDiskStalledDetection: connection to n1 is still alive
(cluster.go:1981).Run: cluster.RunE: context canceled
(cluster.go:1981).Run: output in run_113339.150948350_n4_cockroach-workload-r: ./cockroach workload run kv --read-percent 50 --duration 10m --concurrency 256 --max-rate 2048 --tolerate-errors  --min-block-bytes=512 --max-block-bytes=512 {pgurl:1-3} returned: context canceled

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.disk-stalled/cgroup/read-write/logs-too=true failed with artifacts on release-23.1 @ 27ea509a79d5cdbcf21c53649146d893139e631a:

test artifacts and logs in: /artifacts/disk-stalled/cgroup/read-write/logs-too=true/run_1
(disk_stall.go:176).runDiskStalledDetection: connection to n1 is still alive
(cluster.go:2008).Run: cluster.RunE: context canceled
(cluster.go:2008).Run: output in run_122233.154504960_n4_cockroach-workload-r: ./cockroach workload run kv --read-percent 50 --duration 10m --concurrency 256 --max-rate 2048 --tolerate-errors  --min-block-bytes=512 --max-block-bytes=512 {pgurl:1-3} returned: context canceled

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=true , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

jbowens added a commit to jbowens/cockroach that referenced this issue May 15, 2023
```
9f426d5c Revert "vfs: include size of write in DiskSlowInfo"
949d9808 Revert "vfs: mark file basename as safe to avoid log redaction"
```

Fixes: cockroachdb#103185
Fixes: cockroachdb#102946
Fixes: cockroachdb#102944
Fixes: cockroachdb#102940
Release note: none
nicktrav added a commit to nicktrav/cockroach that referenced this issue May 15, 2023
When addressing an interface change in a recent vendor bump (cockroachdb#102882), a
closure over the existing event listener (passed in via `opts`) was
removed in favor of instantiating Pebble's event listener directly. This
had the effect of dropping disk slow events.

Revert to using a function that closed over the `opts`, making use of
the existing event listener.

Fixes: cockroachdb#103185
Fixes: cockroachdb#102946
Fixes: cockroachdb#102944
Fixes: cockroachdb#102940

Release note: None.
@nicktrav nicktrav self-assigned this May 15, 2023
@nicktrav
Copy link
Collaborator

Done in #103339.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-storage Storage Team
Projects
Archived in project
Development

No branches or pull requests

2 participants