Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: disable kv.expiration_leases_only.enabled metamorphism under deadlock #102591

Conversation

erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Apr 28, 2023

TestClusters are usually so slow under deadlock detection that they're unable to maintain leases/leadership/liveness, especially with expiration leases.

Resolves #101612.
Resolves #101613.
Resolves #101625.
Resolves #101626.
Resolves #102519.

Epic: none
Release note: None

…der deadlock

TestClusters are usually so slow under deadlock detection that they're
unable to maintain leases/leadership/liveness, especially with
expiration leases.

Epic: none
Release note: None
@erikgrinaker erikgrinaker requested a review from a team April 28, 2023 13:31
@erikgrinaker erikgrinaker self-assigned this Apr 28, 2023
@erikgrinaker erikgrinaker requested a review from a team as a code owner April 28, 2023 13:31
@blathers-crl
Copy link

blathers-crl bot commented Apr 28, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 28, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment