-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: kvserver: re-enable kv.expiration_leases_only.enabled
test metamorphism
#101606
Merged
erikgrinaker
merged 2 commits into
release-23.1
from
blathers/backport-release-23.1-101109
May 8, 2023
Merged
release-23.1: kvserver: re-enable kv.expiration_leases_only.enabled
test metamorphism
#101606
erikgrinaker
merged 2 commits into
release-23.1
from
blathers/backport-release-23.1-101109
May 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.1-101109
branch
from
April 16, 2023 12:56
6cce6c7
to
594c3e0
Compare
blathers-crl
bot
added
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
labels
Apr 16, 2023
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.1-101109
branch
from
April 16, 2023 12:56
197d6fd
to
e71fecf
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
andrewbaptist
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing some more flakes on master, going to let this sit for now. |
…hism The test flakiness should have been addressed by eager lease extensions. Epic: none Release note: None
…der deadlock TestClusters are usually so slow under deadlock detection that they're unable to maintain leases/leadership/liveness, especially with expiration leases. Epic: none Release note: None
erikgrinaker
force-pushed
the
blathers/backport-release-23.1-101109
branch
from
May 8, 2023 10:43
e71fecf
to
c5c06e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #101109, 1/1 commits from #102591 on behalf of @erikgrinaker.
/cc @cockroachdb/release
The test flakiness should have been addressed by eager lease extensions.
Epic: none
Release note: None
Release justification: