Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: kvserver: re-enable kv.expiration_leases_only.enabled test metamorphism #101606

Merged
merged 2 commits into from
May 8, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 16, 2023

Backport 1/1 commits from #101109, 1/1 commits from #102591 on behalf of @erikgrinaker.

/cc @cockroachdb/release


The test flakiness should have been addressed by eager lease extensions.

Epic: none
Release note: None


Release justification:

@blathers-crl blathers-crl bot requested a review from a team April 16, 2023 12:56
@blathers-crl blathers-crl bot requested a review from a team as a code owner April 16, 2023 12:56
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-101109 branch from 6cce6c7 to 594c3e0 Compare April 16, 2023 12:56
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 16, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-101109 branch from 197d6fd to e71fecf Compare April 16, 2023 12:56
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 16, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@andrewbaptist andrewbaptist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@erikgrinaker
Copy link
Contributor

Seeing some more flakes on master, going to let this sit for now.

…hism

The test flakiness should have been addressed by eager lease extensions.

Epic: none
Release note: None
…der deadlock

TestClusters are usually so slow under deadlock detection that they're
unable to maintain leases/leadership/liveness, especially with
expiration leases.

Epic: none
Release note: None
@erikgrinaker erikgrinaker force-pushed the blathers/backport-release-23.1-101109 branch from e71fecf to c5c06e3 Compare May 8, 2023 10:43
@erikgrinaker erikgrinaker merged commit 4f66d6e into release-23.1 May 8, 2023
@erikgrinaker erikgrinaker deleted the blathers/backport-release-23.1-101109 branch May 8, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants