Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: leaktest: ignore pgconn async close worker #102586

Closed

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 28, 2023

Backport 1/1 commits from #102258 on behalf of @lidorcarmel.

/cc @cockroachdb/release


Unfortunately I cannot repro this locally :(

Epic: none

Fixes: #97698
Fixes: #97346

Release note: None


Release justification: fixes flaky test

Epic: none

Fixes: #97698
Fixes: #97346

Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-102258 branch from 7f64580 to a10fa17 Compare April 28, 2023 12:24
@blathers-crl blathers-crl bot added the blathers-backport This is a backport that Blathers created automatically. label Apr 28, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-102258 branch from 87de1d5 to ce33335 Compare April 28, 2023 12:24
@blathers-crl blathers-crl bot added the O-robot Originated from a bot. label Apr 28, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 28, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@msbutler
Copy link
Collaborator

should we close this in favor of #102642?

@github-actions
Copy link

Reminder: it has been 3 weeks please merge or close your backport!

@lidorcarmel
Copy link
Contributor

we can close in favor of #102736

@rafiss rafiss deleted the blathers/backport-release-23.1-102258 branch December 11, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. no-backport-pr-activity O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants