leaktest: ignore pgconn async close worker #102258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Epic: none Fixes: cockroachdb#97698 Fixes: cockroachdb#97346 Release note: None
|
This change is |
msbutler
approved these changes
Apr 25, 2023
|
Thanks! |
|
Build succeeded: |
|
blathers backport 23.1 |
lidorcarmel
added a commit
to lidorcarmel/cockroach
that referenced
this pull request
May 1, 2023
We see those in c2c unit tests when using pg connections between the 2 clusters. Note that we already ignored one of those stack traces here cockroachdb#102258 and then reverted that change: cockroachdb@8ecc8f6 but later we saw that we need to ignore both stacks because of cockroachdb#102672. The first fix above was not enough, it was ignoring only one stack. Epic: none Fixes: cockroachdb#97698 Fixes: cockroachdb#97346 Fixes: cockroachdb#102672 Release note: None
craig bot
pushed a commit
that referenced
this pull request
May 2, 2023
102706: leaktest: ignore pgconn leaked goroutines r=lidorcarmel a=lidorcarmel We see those in c2c unit tests when using pg connections between the 2 clusters. Note that we already ignored one of those stack traces here #102258 and then reverted that change: 8ecc8f6 but later we saw that we need to ignore both stacks because of #102672. The first fix above was not enough, it was ignoring only one stack. Epic: none Fixes: #97698 Fixes: #97346 Fixes: #102672 Release note: None Co-authored-by: Lidor Carmel <[email protected]>
blathers-crl bot
pushed a commit
that referenced
this pull request
May 2, 2023
We see those in c2c unit tests when using pg connections between the 2 clusters. Note that we already ignored one of those stack traces here #102258 and then reverted that change: 8ecc8f6 but later we saw that we need to ignore both stacks because of #102672. The first fix above was not enough, it was ignoring only one stack. Epic: none Fixes: #97698 Fixes: #97346 Fixes: #102672 Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately I cannot repro this locally :(
Epic: none
Fixes: #97698
Fixes: #97346
Release note: None