copy: fix vectorized copy for INT2 and INT4 #102298
Merged
+54
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a recently introduced bug where we forgot to implement the special behavior in the vec handler for INT2 and INT4 types which would then could lead to a runtime crash if such a type is used in the schema. Int types are special because the vectorized engine handles them precisely (i.e. it uses int16, int32, and int64 accordingly) whereas the row engine always internally defaults to int64. Release note (bug fix): In alpha and beta 23.1.0 releases CockroachDB could crash when evaluating COPY command in some cases when the schema had INT2 and / or INT4 type, and this is now fixed.
yuzefovich
added
backport-23.1.x
|
This change is |
DrewKimball
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mgartner)
|
TFTR! bors r+ |
|
Build succeeded: |
This was referenced Apr 26, 2023
|
Thanks Yahor! Weird that the randgen test didn't catch this, I'll create an issue to figure out why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a recently introduced bug where we forgot to implement the special behavior in the vec handler for INT2 and INT4 types which would then could lead to a runtime crash if such a type is used in the schema. Int types are special because the vectorized engine handles them precisely (i.e. it uses int16, int32, and int64 accordingly) whereas the row engine always internally defaults to int64.
Fixes: #102181.
Release note (bug fix): In alpha and beta 23.1.0 releases CockroachDB could crash when evaluating COPY command in some cases when the schema had INT2 and / or INT4 type, and this is now fixed.