sql: v23.1.0-beta.2: incorrect int type used in copy

[cockroach-teamcity]

This issue was autofiled by Sentry. It represents a crash or reported error on a live cluster with telemetry enabled.

Sentry link: https://cockroach-labs.sentry.io/issues/4123024665/?referrer=webhooks_plugin

Panic message:

conn_executor.go:865: interface conversion: coldata.Column is coldata.Int32s, not coldata.Int64s
(1) attached stack trace
-- stack trace:
| github.com/cockroachdb/cockroach/pkg/sql.(*Server).ServeConn.func1
| github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:865
| [...repeated from below...]
Wraps: (2) attached stack trace
-- stack trace:
| github.com/cockroachdb/cockroach/pkg/sql.(*Server).ServeConn.func1
| github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:865
| runtime.gopanic
| GOROOT/src/runtime/panic.go:884
| runtime.panicdottypeE
| GOROOT/src/runtime/iface.go:262
| runtime.panicdottypeI
| GOROOT/src/runtime/iface.go:272
| github.com/cockroachdb/cockroach/pkg/col/coldata.(*memColumn).Int64
| github.com/cockroachdb/cockroach/pkg/col/coldata/vec.go:233
| github.com/cockroachdb/cockroach/pkg/col/coldataext.MakeVecHandler
| github.com/cockroachdb/cockroach/pkg/col/coldataext/vec_handler.go:40
| github.com/cockroachdb/cockroach/pkg/sql.(*copyMachine).initVectorizedCopy
| github.com/cockroachdb/cockroach/pkg/sql/copy_from.go:456
| github.com/cockroachdb/cockroach/pkg/sql.newCopyMachine
| github.com/cockroachdb/cockroach/pkg/sql/copy_from.go:354
| github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execCopyIn
| github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2953
| github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execCmd
| github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2310
| github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).run
| github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2067
| github.com/cockroachdb/cockroach/pkg/sql.(*Server).ServeConn
| github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:867
| github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).processCommandsAsync.func1
| github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:738
| runtime.goexit
| GOROOT/src/runtime/asm_amd64.s:1594
Wraps: (3) interface conversion: coldata.Column is coldata.Int32s, not coldata.Int64s
Error types: (1) *withstack.withStack (2) *withstack.withStack (3) *runtime.TypeAssertionError
-- report composition:
*runtime.TypeAssertionError
conn_executor.go:865: *withstack.withStack (top exception)
conn_executor.go:865: *withstack.withStack (1)
(check the extra data payloads)

Stacktrace (expand for inline code snippets):

cockroach/pkg/sql/conn_executor.go

Lines 864 to 866 in 82d4b56

	r := recover()
	h.ex.closeWrapper(ctx, r)
	}(ctx, h)

in pkg/sql.(*Server).ServeConn.func1
GOROOT/src/runtime/panic.go#L883-L885 in runtime.gopanic
GOROOT/src/runtime/iface.go#L261-L263 in runtime.panicdottypeE
GOROOT/src/runtime/iface.go#L271-L273 in runtime.panicdottypeI

cockroach/pkg/col/coldata/vec.go

Lines 232 to 234 in 82d4b56

	func (m *memColumn) Int64() Int64s {
	return m.col.(Int64s)
	}

in pkg/col/coldata.(*memColumn).Int64

cockroach/pkg/col/coldataext/vec_handler.go

Lines 39 to 41 in 82d4b56

	case types.IntFamily:
	v.ints = vec.Int64()
	case types.FloatFamily:

in pkg/col/coldataext.MakeVecHandler

cockroach/pkg/sql/copy_from.go

Lines 455 to 457 in 82d4b56

	for i := range typs {
	c.valueHandlers[i] = coldataext.MakeVecHandler(c.batch.ColVec(i))
	}

in pkg/sql.(*copyMachine).initVectorizedCopy

cockroach/pkg/sql/copy_from.go

Lines 353 to 355 in 82d4b56

	if c.canSupportVectorized(tableDesc) {
	c.initVectorizedCopy(ctx, typs)
	} else {

in pkg/sql.newCopyMachine

cockroach/pkg/sql/conn_executor.go

Lines 2952 to 2954 in 82d4b56

	p := ex.planner
	cm, copyErr = newCopyMachine(
	ctx, cmd.Conn, cmd.Stmt, &p, txnOpt, ex.state.mon, ex.implicitTxn(),

in pkg/sql.(*connExecutor).execCopyIn

cockroach/pkg/sql/conn_executor.go

Lines 2309 to 2311 in 82d4b56

	stmtCtx := withStatement(ctx, tcmd.Stmt)
	ev, payload = ex.execCopyIn(stmtCtx, tcmd, copyRes)

in pkg/sql.(*connExecutor).execCmd

cockroach/pkg/sql/conn_executor.go

Lines 2066 to 2068 in 82d4b56

	var err error
	if err = ex.execCmd(); err != nil {
	// Both of these errors are normal ways for the connExecutor to exit.

in pkg/sql.(*connExecutor).run

cockroach/pkg/sql/conn_executor.go

Lines 866 to 868 in 82d4b56

	}(ctx, h)
	return h.ex.run(ctx, s.pool, reserved, cancel)
	}

in pkg/sql.(*Server).ServeConn

cockroach/pkg/sql/pgwire/conn.go

Lines 737 to 739 in 82d4b56

	reservedOwned = false // We're about to pass ownership away.
	retErr = sqlServer.ServeConn(ctx, connHandler, reserved, cancelConn)
	}()

in pkg/sql/pgwire.(*conn).processCommandsAsync.func1
GOROOT/src/runtime/asm_amd64.s#L1593-L1595 in runtime.goexit

pkg/sql/conn_executor.go in pkg/sql.(*Server).ServeConn.func1 at line 865
GOROOT/src/runtime/panic.go in runtime.gopanic at line 884
GOROOT/src/runtime/iface.go in runtime.panicdottypeE at line 262
GOROOT/src/runtime/iface.go in runtime.panicdottypeI at line 272
pkg/col/coldata/vec.go in pkg/col/coldata.(*memColumn).Int64 at line 233
pkg/col/coldataext/vec_handler.go in pkg/col/coldataext.MakeVecHandler at line 40
pkg/sql/copy_from.go in pkg/sql.(*copyMachine).initVectorizedCopy at line 456
pkg/sql/copy_from.go in pkg/sql.newCopyMachine at line 354
pkg/sql/conn_executor.go in pkg/sql.(*connExecutor).execCopyIn at line 2953
pkg/sql/conn_executor.go in pkg/sql.(*connExecutor).execCmd at line 2310
pkg/sql/conn_executor.go in pkg/sql.(*connExecutor).run at line 2067
pkg/sql/conn_executor.go in pkg/sql.(*Server).ServeConn at line 867
pkg/sql/pgwire/conn.go in pkg/sql/pgwire.(*conn).processCommandsAsync.func1 at line 738
GOROOT/src/runtime/asm_amd64.s in runtime.goexit at line 1594

Tag	Value
Cockroach Release	v23.1.0-beta.2
Cockroach SHA:	82d4b56
Platform	linux amd64
Distribution	CCL
Environment	v23.1.0-beta.2
Command	start-single-node
Go Version	``
# of CPUs
# of Goroutines

Jira issue: CRDB-27328

[yuzefovich]

Reopening until #102307 is merged.

[rafiss]

Thank you for picking this up so quickly. This sentry report came from our testing of psycopg with 23.1.0-beta, done by our psycopg partner.

[mgartner]

Closed by #102307.