-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1.0: ui: add timescale to diag details page #101803
release-23.1.0: ui: add timescale to diag details page #101803
Conversation
Fixes #92417 This commit adds a time scale picker to the Diagnostics tab on Statement Details page. The time scale is aligned with the other ones, and now is possible to see bundles from only the selected period. This commit also makes some UX updates on the same tab, making it use the same SortedTable component as other pages, removing the white background and title to align with all other pages that no longer have those items. Release note (ui change): Add a time scale selector to the Diagnostics tab under the Statement Details page, make it possible to see bundles only from the selected period.
d428cb7
to
75c650c
Compare
6ae09d9
to
dd664d0
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @maryliag and @xinhaoz)
Backport 1/1 commits from #101489 on behalf of @maryliag.
/cc @cockroachdb/release
Fixes #92417
This commit adds a time scale picker to the Diagnostics
tab on Statement Details page. The time scale is aligned
with the other ones, and now is possible to see bundles
from only the selected period.
This commit also makes some UX updates on the same tab,
making it use the same SortedTable component as other pages,
removing the white background and title to align with
all other pages that no longer have those items.
Before
After
https://www.loom.com/share/69f024c0523c4a8c814276f2786ab8a8
Release note (ui change): Add a time scale selector to the Diagnostics
tab under the Statement Details page, make it possible to see bundles
only from the selected period.
Release justification: small change, big impact