Add time selector to the Diagnostics tab including collection time #92417
Assignees
Labels
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Comments
kevin-v-ngo
added
the
C-enhancement
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Apr 14, 2023
Fixes cockroachdb#92417 This commit adds a time scale picker to the Diagnostics tab on Statement Details page. The time scale is aligned with the other ones, and now is possible to see bundles from only the selected period. This commit also makes some UX updates on the same tab, making it use the same SortedTable component as other pages, removing the white background and title to align with all other pages that no longer have those items. Release note (ui change): Add a time scale selector to the Diagnostics tab under the Statement Details page, make it possible to see bundles only from the selected period.
craig bot
pushed a commit
that referenced
this issue
Apr 18, 2023
101489: ui: add timescale to diag details page r=maryliag a=maryliag Fixes #92417 This commit adds a time scale picker to the Diagnostics tab on Statement Details page. The time scale is aligned with the other ones, and now is possible to see bundles from only the selected period. This commit also makes some UX updates on the same tab, making it use the same SortedTable component as other pages, removing the white background and title to align with all other pages that no longer have those items. Before <img width="1539" alt="Screenshot 2023-04-13 at 11 12 04 AM" src="https://user-images.githubusercontent.com/1017486/231869218-75499e39-6bdd-4814-b53f-4c4ddce2c299.png"> After <img width="1539" alt="Screenshot 2023-04-13 at 3 47 12 PM" src="https://user-images.githubusercontent.com/1017486/231869268-d3c659c4-fdcf-4a23-afb7-50553854c1ed.png"> <img width="1546" alt="Screenshot 2023-04-13 at 3 47 21 PM" src="https://user-images.githubusercontent.com/1017486/231869270-ed585ffb-2b85-46a2-8eb3-bc157389880f.png"> https://www.loom.com/share/69f024c0523c4a8c814276f2786ab8a8 Release note (ui change): Add a time scale selector to the Diagnostics tab under the Statement Details page, make it possible to see bundles only from the selected period. 101780: sql: use curDB as test session db instead of hard coded string r=chengxiong-ruan a=chengxiong-ruan Previously, a mistake was made that "defaultdb" is always used as the session current db when constructing the reference provider. This commit fixes it to use the input `curDB`. Epic: None Release note: None 101791: rowexec: fix projection on top of EXPORT r=yuzefovich a=yuzefovich Previously, in the EXPORT processors we hard-coded empty `PostProcessSpec`. This was incorrect in case we have a projection or rendering on top of the EXPORT - in such a scenario we would still simply push out rows as they were produced by the EXPORT core (meaning have exactly `ExportColumns` schema with three columns). This could either lead to panics (like index out of bounds) or incorrect results (say we asked for `length(filename)` instead of `filename` column itself). This is now fixed. Fixes: #101733. Release note (bug fix): CockroachDB previously incorrectly evaluated EXPORT statements that had projection or rendering on top of the EXPORT (e.g. `WITH cte AS (EXPORT INTO CSV 'nodelocal://1/export1/' FROM SELECT * FROM t) SELECT filename FROM cte;` wouldn't work) - such statements would result in panics or incorrect query results. Note that the exported data wasn't affected, only the presentation of the query result. The bug has been present since 22.1 or earlier. Co-authored-by: maryliag <[email protected]> Co-authored-by: Chengxiong Ruan <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]>
blathers-crl bot
pushed a commit
that referenced
this issue
Apr 18, 2023
Fixes #92417 This commit adds a time scale picker to the Diagnostics tab on Statement Details page. The time scale is aligned with the other ones, and now is possible to see bundles from only the selected period. This commit also makes some UX updates on the same tab, making it use the same SortedTable component as other pages, removing the white background and title to align with all other pages that no longer have those items. Release note (ui change): Add a time scale selector to the Diagnostics tab under the Statement Details page, make it possible to see bundles only from the selected period.
blathers-crl bot
pushed a commit
that referenced
this issue
Apr 18, 2023
Fixes #92417 This commit adds a time scale picker to the Diagnostics tab on Statement Details page. The time scale is aligned with the other ones, and now is possible to see bundles from only the selected period. This commit also makes some UX updates on the same tab, making it use the same SortedTable component as other pages, removing the white background and title to align with all other pages that no longer have those items. Release note (ui change): Add a time scale selector to the Diagnostics tab under the Statement Details page, make it possible to see bundles only from the selected period.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue breaks down #90292 and #82896 (comment) in the context of statement bundles.
The time selector and selected ranges should persist across all console pages to allow for correlation, especially for scenarios when troubleshooting outliers.
Related issues
Epic: CRDB-8649
Jira issue: CRDB-21756
The text was updated successfully, but these errors were encountered: