Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud/amazon: print out asserted error in TestS3BucketDoesNotExist #100740

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

rhu713
Copy link
Contributor

@rhu713 rhu713 commented Apr 5, 2023

Add a message that prints out the error being asserted on in TestS3BucketDoesNotExist.

Will give more info to test failures like #100671 if this fails again.

Release note: None

Add a message that prints out the error being asserted on
in TestS3BucketDoesNotExist.

Release note: None
@rhu713 rhu713 requested a review from a team as a code owner April 5, 2023 18:15
@rhu713 rhu713 requested review from benbardin and removed request for a team April 5, 2023 18:15
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rhu713
Copy link
Contributor Author

rhu713 commented Apr 13, 2023

bors r+

1 similar comment
@rhu713
Copy link
Contributor Author

rhu713 commented Apr 14, 2023

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 14, 2023

Build succeeded:

@craig craig bot merged commit 3bd1d6e into cockroachdb:master Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants