Skip to content

Commit

Permalink
Merge #100740
Browse files Browse the repository at this point in the history
100740: cloud/amazon: print out asserted error in TestS3BucketDoesNotExist r=rhu713 a=rhu713

Add a message that prints out the error being asserted on in TestS3BucketDoesNotExist.

Will give more info to test failures like #100671 if this fails again.

Release note: None

Co-authored-by: Rui Hu <[email protected]>
  • Loading branch information
craig[bot] and Rui Hu committed Apr 14, 2023
2 parents f13081c + b4218ac commit 3bd1d6e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/cloud/amazon/s3_storage_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@ func TestS3BucketDoesNotExist(t *testing.T) {

_, err = s.ReadFile(ctx, "")
require.Error(t, err, "")
require.True(t, errors.Is(err, cloud.ErrFileDoesNotExist))
require.True(t, errors.Is(err, cloud.ErrFileDoesNotExist), "error is not cloud.ErrFileDoesNotExist: %v", err)
}

func TestAntagonisticS3Read(t *testing.T) {
Expand Down

0 comments on commit 3bd1d6e

Please sign in to comment.